pmxbot IRC Log Viewer

[12:45:24] <pmxbot> jaraco pushed 3 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[12:45:24] <pmxbot> Move devguide notes to documentation.

[12:45:24] <pmxbot> Expand on stylistic changes

[12:45:24] <pmxbot> Added Recommended Reading

[13:05:02] <pmxbot> jaraco pushed 7 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[13:05:02] <pmxbot> Expanded on Project Management

[13:05:02] <pmxbot> Added note about Github mirror

[13:05:02] <pmxbot> Updated recommeded testing procedure.

[13:05:02] <pmxbot> Expanded on authoring tickets.

[13:05:02] <pmxbot> Expose developer guide in the documentation.

[13:05:02] <pmxbot> Update changelog to reflect incidental change in 5.0.

[13:05:02] <pmxbot> Update changelog

[13:11:51] <pmxbot> jaraco pushed 3 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[13:11:51] <pmxbot> Fix pep8 issues for install_egg_info

[13:11:51] <pmxbot> Clean up _get_all_ns_packages

[13:11:51] <pmxbot> Merge pull request #10 from Ivoz/install_egg_info-cleanup

[13:14:50] <Ivo> jaraco: you intend to get to https://bitbucket.org/pypa/setuptools/pull-request/67/fixed-pep-8-compliancy-of-the ?

[13:15:14] <Ivo> or would you prefer it in another form?

[13:15:15] <jaraco> sure

[13:15:20] <jaraco> I'll take a look now.

[13:25:36] <pmxbot> jaraco pushed 2 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[13:25:36] <pmxbot> Fixed PEP 8 compliancy of the setuptools.command package

[13:25:36] <pmxbot> Merge Pull Request 67 from bb://agronholm/bitbucket

[13:27:04] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[13:27:04] <pmxbot> Remove trailing newline

[13:40:10] <Ivo> jaraco: does setuptools/command/easy_install, or setuptools in general, worry about needing to install symlinks?

[13:40:25] <Ivo> or would it only care about files

[13:40:42] <jaraco> Ivo, I'm unsure.

[13:40:47] <Ivo> my context is https://bitbucket.org/pypa/setuptools/issue/118

[13:41:22] <Ivo> So I'm just filtering the record, but I'm wondering whether most appropriate is `not os.path.isdir` or `os.path.isfile`

[13:43:03] <Ivo> can setuptools install symlinks?

[13:44:27] <jaraco> I'm not aware of any case where it installs symlinks, but I can't say with confidence that it never does.

[13:45:00] <jaraco> In either case, os.path.isdir and os.path.isfile resolve to the type of the target, no?

[13:45:34] <jaraco> So I would expect either to be consistent even if symlinks are involved.

[13:46:04] <Ivo> `not isdir` would 'allow symlinks' to be recorded, in the case that that's a valid thing to do; `isfile` would not record symlinks

[13:46:12] <Ivo> this is taking its input from self.outputs

[13:47:21] <Ivo> if its not a valid thing to do then you'd use `isfile`, or if its not possible then it hsouldn't matter either way

[13:48:04] <jaraco> http://paste.jaraco.com/XthJ5

[13:48:43] <jaraco> os.path.isdir and os.path.isfile just pass through the result of whatever the symlink points to.

[13:49:07] <jaraco> So for the sake of 'recording', I don't see how it's relevant whether a symlink is involved or not.

[13:50:02] <jaraco> Or if it is relevant, one would invoke 'islink' to determine the status.

[13:51:27] <Ivo> you can see exactly what I'm asking about in https://github.com/jaraco/setuptools/pull/11

[13:52:38] <Ivo> jaraco: if you like I could add entries to CHANGES.txt along with bugfixing PRs

[13:53:28] <Ivo> http://jaraco.com/ lolz

[13:54:12] <jaraco> :)

[13:54:27] <Ivo> you should put up a tiny about me or smth when you have an hour

[13:55:02] <jaraco> oh

[13:55:05] <jaraco> it's broken

[13:55:06] <jaraco> weird

[13:55:16] <Ivo> oh right

[13:56:56] <jaraco> There used to be a page there. I think a Windows Update must have replaced it.

[13:57:04] <jaraco> !dm Microsoft

[13:57:04] <pmxbot> you're doing horrible work, Microsoft!

[13:57:26] <Ivo> sadface

[13:59:43] <jaraco> Ivo, http://www.jaraco.com/

[13:59:54] <Ivo> I wonder

[13:59:55] <jaraco> So it's just the raw domain that has no site.

[13:59:57] <Ivo> if there's anything

[14:00:07] <Ivo> that relies on that code modifying self.outputs

[14:00:32] <Ivo> or stops working

[14:00:51] <Ivo> because it does output = self.output

[14:00:54] <Ivo> and then modifies output

[14:01:10] <Ivo> but because that's a list... its modifying self.output as well

[14:01:21] <Ivo> I'd guess, by mistake..

[14:04:03] <Ivo> jaraco: do I call you?

[14:11:32] <pmxbot> jaraco pushed 2 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:11:32] <pmxbot> Extract the lines of the namespace package pth file template for readability.

[14:11:32] <pmxbot> Extract the additional trailing lines when a parent package is indicated.

[14:11:52] <jaraco> Ivo, ?

[14:12:16] <Ivo> you put up a google call me button

[14:12:35] <Ivo> I just find it amusing that you invite people to give you a phone call right on your home page

[14:13:25] <jaraco> I put that there back when it was grandcentral... and when I actually used my phone to initiate communication.

[14:13:32] <jaraco> And when long distance charges were still a thing.

[14:13:45] <jaraco> That web page sure needs some help.

[14:14:08] <jaraco> I'd probably be better off with my home page from 1994.

[14:15:27] <pmxbot> jaraco pushed 2 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:15:27] <pmxbot> Use short-circuit for less nesting

[14:15:27] <pmxbot> Use context manager for opening and closing the file

[14:17:11] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:17:11] <pmxbot> Reindent long line

[14:27:49] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:27:49] <pmxbot> Extract method for generating lines for a pkg in nsp. Fixes issue in 67bdf3a726962 where only the last dat would be written.

[14:31:46] <Ivo> jaraco: some reason you didn't want to just use file.writelines?

[14:32:34] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:32:34] <pmxbot> Update changelog

[14:32:59] <jaraco> Ivo, that's a great idea.

[14:33:06] <jaraco> Does writelines accept an iterable as well as a list?

[14:33:29] <Ivo> I would be blown away if it didn't

[14:33:49] <Ivo> also, your outside list() is kinda useless

[14:34:01] <Ivo> https://bitbucket.org/pypa/setuptools/commits/50c44103cab0f30003bcb3f702a43f7c23a48022#Lsetuptools/command/install_egg_info.pyT77

[14:34:25] <jaraco> is it useless? Without that outside list, on Python 3, that map wouldn't do anything.

[14:34:36] <jaraco> It would just return a generator which would never be consumed.

[14:34:53] <jaraco> Which is why Python really should include a 'consume' function, but I use list as a shorthand.

[14:35:02] <Ivo> ahhhhhh

[14:35:04] <Ivo> tricky that

[14:35:13] <jaraco> yes, writelines works on an iterable.

[14:35:26] <jaraco> !lm Ivo

[14:35:26] <pmxbot> ¡Estás haciendo un buen trabajo, Ivo!

[14:35:36] <Ivo> python is turning into haskell!

[14:35:42] <Ivo> whatever shall we do!

[14:36:21] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:36:21] <pmxbot> Prefer the writelines method.

[14:37:49] <jaraco> I'm thinking the generation of those lines should be included even in a dry_run.

[14:40:45] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:40:45] <pmxbot> Always generate the lines, even in dry run.

[14:42:20] <jaraco> Ivo, are you interested in making a release?

[14:42:29] <Ivo> ...for setuptools?

[14:42:32] <jaraco> yes

[14:42:39] <Ivo> Not specifically

[14:42:54] <Ivo> as in getting a release out, or me myself making a release

[14:43:15] <jaraco> I just thought it would be useful to get more people at least nominally involved in releases to lessen the bus factor.

[14:43:30] <jaraco> I mean running the release script, essentially.

[14:43:52] <jaraco> You'll need access to the repository and PyPI

[14:44:08] <jaraco> But then we'll at least have someone who can do releases other than me.

[14:44:56] <Ivo> I didn't think setuptools specifically warranted a release right now, but apart from being scared of getting to be personally responsible for breaking stuff for people, I'm not really against that :)

[14:45:27] <Ivo> I could be wrong if you think theres enough fixes to warrant a patch release atm though

[14:45:32] <jaraco> There aren't any substantial changes right now, so it's a great time to make a release to ensure that those non-substantive changes don't break anything.

[14:47:07] <jaraco> Do you have a mercurial checkout of setuptools?

[14:48:52] <Ivo> jaraco: how about https://github.com/jaraco/setuptools/pull/11 ?

[14:51:54] <jaraco> Ivo, that looks good, but I'm running out of time today to work on this.

[14:53:27] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:53:27] <pmxbot> Mention Ivoz as release manager

[14:54:47] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[14:54:47] <pmxbot> Write the actual command.

[14:55:01] <jaraco> Ivo, what's your pypi username?

[14:55:26] <Ivo> jaraco: dw about that pr today

[14:55:42] <Ivo> Ivoz

[14:56:16] <jaraco> okay. You're now a maintainer on PyPI and Admin in the setuptools repo, which means you can make releases.

[14:56:51] <jaraco> The instructions are in the releases.txt.

[14:57:08] <jaraco> If you want to make a release, feel free, but I have to go now, so maybe it's best to defer to another time.

[14:57:42] <Ivo> Cool! Ahhhh!

[14:57:49] <Ivo> Thanks, jaraco

[14:58:05] <Ivo> And ya, I'll wait till you're free time sometiime

[15:35:31] <dstufft> so now we get to blame Ivo when things break on setuptools too!

[15:35:43] <Ivo> nooooooooooooooooooo

[15:37:17] <Ivo> dstufft: setuptools getting pep8ified :D

[15:37:48] <dstufft> Ivo: nice

[15:37:58] <dstufft> pep8 really does make things more readable

[15:38:04] <dstufft> I think pip is better having gone through that

[15:38:39] <Ivo> I think its just nice to have a common standard

[15:38:57] <Ivo> or rather, thats the best thing about it

[15:39:17] <Ivo> no more personal opinions to argue over

[15:40:05] <dstufft> as Alex_Gaynor would say, you don't get an opinion

[15:40:10] <Ivo> dstufft: do you think virtualenv removing its virtualenv-X.X script should warrant a minor release?

[15:41:00] <dstufft> probably, but if you do it on develop then it won't matter b/c it'll happen in the next minor release

[15:41:32] <Ivo> atm its just broken for anyone that installs virtualenv with a wheel

[15:41:49] <dstufft> going to be doing a new release in 1-2 months anyways hopefully

[15:42:01] <Ivo> because it relies on a setup.py being run and doesnt get special treatment like pip & easy_install do

[15:42:25] <Ivo> pip install virtualenv on py34 and you get virtualenv2.7 that runs on py34

[15:42:35] <Ivo> lolz

[15:43:45] <Ivo> dstufft: were you hoping to get any rewrite into that prospetive 2 month release, or just a good amount of bugfixes

[15:44:00] <dstufft> I wasn't going to rewrite virtualenv in that 1-2 month release no

[15:44:07] <dstufft> I don't have time for that before then

[15:44:34] <Ivo> nw, just wondering since you said you had a toy thing trying to use pyvenv

[15:52:42] <dstufft> I have a partially done implementation, but not enough time

[15:52:53] <dstufft> trying to get PEP 440 finialized before 1.6

[15:52:59] <dstufft> would love to get PEP 440 final into 1.6

[15:53:11] <Ivo> shure

Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Sunday the 22nd of June, 2014