Log file Viewer

[00:00:12] <dstufft> basically anything you want to show for -v should be logger.debug(), anything you want to appear normally should be logger.info, anything you want to show even with -q should be logger.warning

[00:00:29] <r1chardj0n3s> ok, so I should move away from logger.notify, gotcha

[00:00:42] <r1chardj0n3s> team standup in a couple of minutes; should be back in about 30 :)

[00:00:46] <dstufft> also while stdlib logger does have logger.warn, it's deprecated in favor of logger.warning

[00:00:51] <r1chardj0n3s> [we're working on making the standup move faster ;)]

[00:01:20] <dstufft> r1chardj0n3s: sounds like our standups

[00:03:29] <r1chardj0n3s> remote standups always take longer because it's a chance for chitchat that otherwise would happen randomly in the office

[00:03:33] <dstufft> ya

[00:06:15] <dstufft> r1chardj0n3s: the other things I see: --disable-self-check should probably be more descriptive, esp with the command going away and the other thing is a personal thing, but it'd be cool to use separators=(",", ":"), sort_keys=True to json.dumps() for deterministic output and minimal file size. The json thing I wouldn't fail a review for though so if you disagree that's fine!

[10:36:20] <dstufft> r1chardj0n3s_afk: test failures on the self check PR, not sure if you're still awake. If you don't get to it first i'll probably pull down your branch and fix them and make a new PR. It otherwise looks great to me the test failures are just missing the change from pip.util to pip.utils and left over print statement debugging

[11:39:00] <pmxbot> jaraco pushed 6 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[11:39:00] <pmxbot> Add indicators for PY2 vs. PY3

[11:39:00] <pmxbot> Remove conditional import for frozenset (available in Python 2.6+)

[11:39:00] <pmxbot> Use PY3/PY2 indicators to reliably select behavior. Fixes #237

[11:39:00] <pmxbot> next function and io module are available on Python 2.6

[11:39:00] <pmxbot> Use the term 'string_types', following the pattern in six

[11:39:00] <pmxbot> Remove execfile compatibility - unnecessary on Python 2.6+

[11:44:14] <pmxbot> jaraco pushed 2 commits to setuptools (https://bitbucket.org/pypa/setuptools/) :

[11:44:14] <pmxbot> Added tag 5.8 for changeset 67550a8ed9f4

[11:44:14] <pmxbot> Bumped to 5.9 in preparation for next release.

[22:05:50] <pf_moore> tomprince, dstufft: after the discussion a couple of days ago, I reimplemented vex in powershell, just for fun

[22:05:53] <pf_moore> See https://gist.github.com/pfmoore/21d3450bb413a8713053

[22:06:19] <pf_moore> Still a bit rough round the edges, but surprisingly useful

[22:11:54] <dstufft> pf_moore: nice!

[22:19:59] <pf_moore> dstufft: yeah, powershell's neat. But ugly, took me most of the time to get the parameter declarations right...

[23:09:49] <r1chardj0n3s> er dstufft?

[23:10:59] <dstufft> r1chardj0n3s: wasup

[23:11:22] <r1chardj0n3s> my PR was closed, I am confused :)

[23:11:46] <r1chardj0n3s> oh, wait, that cryptic "closed this in #2049" is the hint

[23:11:55] <r1chardj0n3s> ah, I see

[23:12:01] <r1chardj0n3s> right, good show, carry on

[23:12:30] <dstufft> r1chardj0n3s: I just decided I didn't like your PR!

[23:12:54] <dstufft> It had a bunch of print statements left in it, then it didn't work on Python 2.6 then it didn't work on PyPy

[23:13:40] <r1chardj0n3s> okie

[23:47:40] <dstufft> pf_moore: you around ?

[23:49:07] <r1chardj0n3s> dstufft: well, thanks for fixing up that crap in the PR :)

[23:49:15] <dstufft> r1chardj0n3s: no problem!

[23:49:33] <dstufft> We might have inadvertantly blocked Python 2.6 users from PyPI

[23:49:35] <dstufft> on Windows