PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Saturday the 20th of December, 2014

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[00:10:45] <msabramo1> https://github.com/pypa/pip/pull/2232
[00:51:45] <tomprince> msabramo: I suspect that everybody that cares about pull requests already gets notified about them.
[00:52:08] <msabramo> tomprince: point taken
[00:52:19] <msabramo> apologies
[17:37:09] <tomprince> msabramo: Any reason to rebase, rather than merge that?
[17:37:41] <msabramo> tomprince: I don't know; I rebase out of habit
[17:37:53] <msabramo> maybe merge would be better?
[17:38:20] <msabramo> I wish I could send the PR to benoitbryon
[17:39:25] <tomprince> You can.
[17:39:49] <tomprince> When you create a pull request, you can change what the pull request is against.
[18:07:26] <msabramo1> tomprince: I tried , his repo wasn't in the list of base repos
[18:07:42] <msabramo1> I even tried to create another fork from his repo but you can only have one
[18:08:14] <msabramo1> maybe I should just old skool and email him a patch
[18:11:25] <msabramo1> had to do that the other day for docutils because they're on subversion at sourceforge
[18:11:40] <msabramo1> felt like I was in a time warp
[18:17:17] <tomprince> msabramo1: If you go to a URL like https://github.com/msabramo/pip/compare/benoitbryon:feature/freeze-subset-recursively...feature/freeze-subset-recursively_rebase you should be able to create a pull request.
[18:22:48] <msabramo1> tomprince: cool
[18:23:24] <msabramo1> hmmm that shows a ton of commits
[18:24:26] <tomprince> Well, you probably want to merge rather than rebase, before sending a PR. But it will show all the commits since the original branch was made.
[18:26:00] <msabramo1> tomprince: yeah I messed that up
[18:26:19] <msabramo1> I'm sending him all of the stuff that happened on develop
[18:26:21] <msabramo1> doh
[18:26:35] <tomprince> Well, that is what you need to do, to merge forward.
[19:11:14] <ionelmc> this is terrible, virtualenv is bundling setuptools 3.6
[19:11:22] <ionelmc> which is old :|
[19:22:11] <tomprince> ionelmc: Only 7 months old.
[19:23:07] <tomprince> I think virtualenv tends to get released in sync with pip, and always bundles the latest setuptools at that point.
[19:23:10] <ionelmc> well it's a bit ridiculous to have to upgrade setuptools in the virtualenv (when you already have the latest outside)
[19:23:45] <ionelmc> hopefully this bundling madness will end one day
[19:24:12] <tomprince> You can drop a new version in virtualenv_support.