Log file Viewer

[01:16:18] <lifeless> dstufft: ping :)

[01:17:26] <dstufft> lifeless: heya

[01:18:16] <lifeless> dstufft: could i beg a merge of https://github.com/pypa/pip/pull/2661 ?

[01:18:34] <lifeless> dstufft: also I'm just updating the main PR for wheels, I have done 99% now

[01:23:55] <lifeless> dstufft: https://github.com/pypa/pip/pull/2662 is next up

[01:57:06] <dstufft> lifeless: cool, will take a look in a bit, or tomorrow morning

[02:06:29] <lifeless> dstufft: ack

[02:06:34] <lifeless> dstufft: that one is super shallow

[02:06:48] <dstufft> oh

[02:06:51] <dstufft> I didn't click it

[02:06:55] <dstufft> I thought it was the wheel building one

[02:07:19] <dstufft> merged

[02:07:20] <dstufft> sorry!

[02:09:42] <lifeless> dstufft: :) 2618 is the wheel building one

[02:10:08] <dstufft> that's what I get for not reading the link

[02:11:57] <lifeless> https://github.com/pypa/pip/pull/2663 is another small itemised change, if you're still up when it finishes tests

[02:12:37] <dstufft> ok

[02:13:28] <dstufft> I should be up, I'm just knee deep in some other stuff so can't give anything substanial a deep look, but small stuff is easy

[02:14:50] <dstufft> ha

[02:14:51] <dstufft> :)

[02:14:54] <dstufft> tha'ts one way!

[02:51:54] <lifeless> dstufft: https://github.com/pypa/pip/pull/2663 passed tests

[03:40:07] <lifeless> dstufft: now https://github.com/pypa/pip/pull/2664

[03:40:22] <lifeless> dstufft: (docstring only change)

[04:02:54] <lifeless> dstufft: and now https://github.com/pypa/pip/pull/2665

[04:03:09] <lifeless> dstufft: this will need to run tests, but is still small

[07:35:34] <lifeless> could someone re-run the tests for https://github.com/pypa/pip/pull/2665 ?

[18:59:42] <lifeless> dstufft: https://github.com/pypa/pip/pull/2665

[22:02:42] <lifeless> dstufft: ping - need to talk about direct urls vis a vis wheel building

[22:15:35] <lifeless> https://github.com/pypa/pip/pull/2618 is green again

[22:18:40] <dstufft> lifeless: hey

[22:20:15] <lifeless> dstufft: \o/

[22:24:18] <xafer> hello, just a quick reminder of https://github.com/pypa/pip/pull/2659 :) Any plans/thoughts about a 6.1.2 ?

[22:28:52] <dstufft> xafer: sorry, I've been feeling sick the last few days so I'm not operating at full capacity

[22:31:57] <lifeless> dstufft: Oh ugh, sorry to be pestering you :(. FWIW 2659 looked sane to me

[22:32:00] <xafer> oh sorry to hear that, but no problem, there is no urgency, I was just making sure it isnt left out if a patch version is released :)

[22:32:20] <lifeless> dstufft: (as a 6.1.2 component and as something for develop)

[22:32:58] <dstufft> will merge once the tests pass on the job I just restarted that failed

[22:34:30] <dstufft> lifeless: it's no worries. just spending more time in the bathroom then the computer :V

[22:34:57] <lifeless> dstufft: you need a laptop :>

[22:35:04] <xafer> ^^

[22:35:06] <dstufft> heh

[22:35:22] <dstufft> I have one, I just never use it. I feel cramped on the 15" screen

[22:35:29] <dstufft> compared to my 27"

[22:40:50] <xafer> well, good recovery and thx for the merge, I'm off to bed :)

[23:26:50] <lifeless> dstufft: ok so

[23:27:11] <lifeless> dstufft: if you're up to it, lets talk autobuild wheels

[23:28:23] <lifeless> dstufft: also https://github.com/pypa/pip/pull/2665 can be merged (if you're ok with it :))

[23:30:58] <lifeless> dstufft: AIUI you're worried that if we build wheels for e.g. file paths that they will be stale and cause the wrong thing to be installed

[23:32:08] <dstufft> lifeless: So, part of the concern was with the --find-links thing, I haven't looked at the updated PR yet to know if it's mitigated in another way, but for instance, with the state of the PR I reviewed, pip install . in the pip directory would get a pip 7.0.0.dev0 wheel built in the find-links

[23:32:37] <dstufft> which would "leak" into the set of things that could be installed for every subsequent command

[23:32:41] <lifeless> thats fixed

[23:32:51] <lifeless> it will build a wheel

[23:33:20] <lifeless> but it will only be found if package finder *separately* finds an sdist with the same filename (pip-7.0.0.0.dev0.tgz or whatever)

[23:33:25] <dstufft> ok

[23:34:44] <dstufft> primarily I'm concerned with changes of behavior, particularly between multiple invocations of pip (other than ones related to the fact that we're building wheels which is different then isntalling straight from sdist)

[23:35:23] <lifeless> the specific code is https://github.com/rbtcollins/pip/commit/5b978b691891a99225ecc42262f50ac69ecf29d3#diff-2695f32c4432acd141c3dbe7e7e3a6b0L41

[23:35:37] <dstufft> pretending for a minute that every single thing will work 100% fine being installed from a wheel, then the goal would be to make the fact that there is a wheel cache as transparent as possible and not introduce wierdness from it being enabled

[23:35:53] <dstufft> looking

[23:37:01] <lifeless> and I made req_to_install.link into a property

[23:37:03] <lifeless> https://github.com/rbtcollins/pip/commit/5b978b691891a99225ecc42262f50ac69ecf29d3#diff-297395da5417032dc5d0738a1fc7e136R245

[23:37:26] <lifeless> so that when its set, it triggers that lookup

[23:37:32] <lifeless> no change to the finding-of-links code

[23:37:56] <lifeless> so the specific assumption is that 'filename

[23:38:18] <lifeless> is a good unique key to find possible wheels

[23:41:11] <lifeless> thinking about it, I think we should reject anything that doesn't look like an sdist - e.g. if its local and not a file, or if its remote and doesn't have version info

[23:42:41] <lifeless> [I presume there's a handy regex around somewhere already :))]

[23:55:18] <lifeless> dstufft: I don't understand the sorting thing - we're going to be building all the wheels the same, right ?

[23:55:31] <lifeless> dstufft: when would we produce compatible-but-less-desirable wheels?

[23:59:28] <dstufft> lifeless: it's basically a hedge against a possible "less than desireable" error case, right now if you have a wheel that has an optional c extension that you just omit on PyPy in your setup.py you'll get a pure python wheel if you build it on PyPy but a compiled wheel if you build it on CPython

[23:59:42] <dstufft> even with sorting, if you build it on PyPy first you won't get the compiled wheel ever

[23:59:51] <lifeless> ah, ok.

[23:59:53] <lifeless> can do

[23:59:56] <dstufft> but at least with sorting if you install it on CPython first you'll get the compiled wheel