Log file Viewer

[17:13:44] <ronny> re

[17:14:03] <ronny> dstufft: btw, how close is warehouse to ready for switch?

[22:09:50] <iElectric> ronny: not nearly close

[22:10:15] <iElectric> dstufft: I don't see how tests work for you

[22:10:20] <iElectric> apparently I'm missing

[22:10:22] <iElectric> CREATE EXTENSION "pgcrypto";

[22:10:29] <iElectric> but that should be part of test setup?

[22:10:53] <dstufft> https://github.com/pypa/warehouse/blob/master/warehouse/migrations/versions/128a0ead322_add_primary_key_roles.py#L29

[22:14:37] <iElectric> dstufft: gen_random_uuid() is used before that migration

[22:14:58] <iElectric> in 5988e3e8d2e_add_primary_key_to_release_files.py

[22:16:41] <iElectric> aha there is even one migrations before that

[22:16:53] <iElectric> not sure why it fails to create the extension..

[22:18:37] <iElectric> I use 9.4beta3

[22:18:44] <iElectric> maybe I should upgrade to final release

[22:19:14] <dstufft> iElectric: huh?

[22:19:35] <dstufft> iElectric: the down migration for add_primary_key_roles is 283c68f2ab2

[22:19:35] <iElectric> E sqlalchemy.exc.ProgrammingError: (ProgrammingError) function gen_random_uuid() does not exist

[22:19:37] <iElectric> E HINT: No function matches the given name and argument types. You might need to add explicit type casts.

[22:19:39] <iElectric> E 'ALTER TABLE roles ADD COLUMN id UUID DEFAULT gen_random_uuid() NOT NULL' {}

[22:19:41] <dstufft> which is the initial migration

[22:20:00] <iElectric> yeah that one if failing

[22:20:05] <iElectric> but it has CREATE EXTENSION clause

[22:20:07] <iElectric> so wtf.

[22:20:18] <iElectric> s/if/is/

[22:46:07] <iElectric> woot

[22:46:09] <iElectric> it works

[22:46:31] <dstufft> iElectric: \i/

[22:46:33] <dstufft> success

[22:47:05] <iElectric> pytest-dbfixtures dies on betas

[22:47:07] <iElectric> will fix that

[23:02:38] <iElectric> dstufft: https://github.com/pypa/warehouse/pull/502

[23:08:53] <iElectric> berker: nit-picking css/html now is probably redundant since it may change

[23:09:13] <trishank> good stuff, iElectric

[23:11:10] <iElectric> I try :)

[23:14:31] <berker> iElectric: I wouldn't say "nitpicking" since the review wasn't about code style, indendation etc.

[23:15:02] <iElectric> I'm saying markup is provisional

[23:21:11] <berker> well, provisional or not the markup is not valid HTML. I'm just a contributor anyway, feel free to ignore my comments

[23:22:19] <iElectric> I appreciate the review, I'll fix comments that do not address dead semantic web :)

[23:36:22] <berker> the semantic comment wasn't about "semantic web" at all. styling recent releases list with a class named "comment" is just confusing