Log file Viewer

[11:04:20] <ronny> dstufft: any oppinions on the 2 pip issues i opened

[17:58:02] <lifeless> dstufft: morning

[17:58:31] <dstufft> lifeless: running to grab lunch, will be back in like 30 or so

[18:02:48] <lifeless> dstufft: k

[18:03:02] <lifeless> dstufft: I want to push through the markers fix in requirements asap

[18:03:25] <lifeless> dstufft: so seeking explicit do X dfeedback

[18:22:52] <sigmavirus24> /goto bops

[18:52:25] <dstufft> lifeless: back now

[19:04:12] <lifeless> hi\

[19:07:38] <dstufft> lifeless: heya

[19:09:47] <lifeless> just wrapping up a tweak to qwcodes PR

[19:14:15] <lifeless> pushed up into PR 2841

[19:14:30] <lifeless> it has qwcodes code rebased with conflicts fixed, plus more prose from me in the docs.

[19:15:13] <lifeless> oh, forgot one thing. sec

[19:17:34] <lifeless> dstufft: ok, pushed that up

[19:17:43] <lifeless> dstufft: (just CHANGES tweaks)

[19:17:59] <lifeless> dstufft: getting this fixed before the `` rot spreads too far is urgent IMO

[19:18:10] <lifeless> dstufft: please let me know what else I can do to help a 7.0.2 happen

[19:19:08] <dstufft> lifeless: which PR is this

[19:41:37] <sigmavirus24> 2841?

[19:41:49] <lifeless> dstufft: 2841 and 2844

[19:47:46] <lifeless> dstufft: 2841 *was* my alternate attempt, then qwcode put up 2844, and I've rebased that to fix conflicts and added docs on top of i, pushed back into 1841

[19:47:50] <lifeless> erm 2841

[19:47:59] <dstufft> ok

[21:01:19] <dstufft> lifeless: does this PR make it so that quotes no longer work at all around specifiers containing environment markers?

[21:04:19] <lifeless> dstufft: yes, it restores the 6.0 behaviour entirely/

[21:04:32] <dstufft> ok

[21:04:36] <lifeless> dstufft: we've only had ~1 week with the 7.0 behaviour, so I think thats ok

[21:04:58] <lifeless> dstufft: I called this out in CHANGES.txt

[21:05:07] <dstufft> yea

[21:05:29] <dstufft> was just making sure I understood the changes

[21:11:44] <lifeless> dstufft: cooll; so whats the process to get that into master + a 7.0.2 release cut?

[21:12:22] <dstufft> lifeless: I'm taking a look at https://github.com/pypa/pip/milestones/7.0.2 to see if there's anything I can do quickly before doing that, but the process itself is manual on my end until we get some automation done :/

[21:47:28] <lifeless> dstufft: ok, so just the one 7.0.2 thing to do

[21:47:31] <lifeless> dstufft: which you've done

[22:35:16] <dstufft> lifeless: https://github.com/pypa/pip/pull/2854

[22:37:21] <lifeless> \o/