PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Friday the 19th of June, 2015

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[00:37:20] <tchaypo> lifeless: sorry for delay, but https://github.com/jamezpolley/pip/tree/con_and_dep is the branch with the test I added yesterday
[00:45:39] <lifeless> ok
[00:45:43] <lifeless> so the failure about having a build dir
[00:45:48] <lifeless> shows we're hitting the problem
[00:47:12] <lifeless> which is great
[00:47:13] <lifeless> so
[00:47:27] <lifeless> I think the answer is to put a 'prepared=False' attribute on InstallRequirement
[00:47:45] <lifeless> set that to True right after the guard line at the top of _prepare_file
[00:47:59] <lifeless> and add a second guard that says if req_to_install.prepared: return []
[00:48:11] <lifeless> with a comment explaining why we might see something twice
[02:01:58] <lifeless> tchaypo: did that make sense ?
[03:59:06] <tchaypo> yes
[04:59:40] <tchaypo> lifeless: ^^^
[05:00:42] <tchaypo> so that (A) passes tests, and (B) in my test environment, doesn’t crash
[05:11:27] <tchaypo> and does instal things. So I’m reasonably confident it handles your case.
[06:37:15] <lifeless> dstufft: https://github.com/pypa/pip/pull/2917 plox
[06:37:29] <lifeless> tchaypo: great, pick another outsourced thing from trello :)
[07:38:33] <tchaypo> lifeless: I’m looking at them and many of them are very brief and I’m not sure what they mean or which ones are important
[07:40:51] <lifeless> tchaypo: so lets get all of constraints burnt down
[07:41:24] <lifeless> so poking at devstack
[07:41:58] <lifeless> with a) the fixed pip patch + my WIP patch for using constraints files + my in-progress upper-constraints review of requirements would be next I think
[07:42:06] <lifeless> when thats managing to run tempest
[07:42:24] <lifeless> the next step would be to get the reverse jobs setup in zuul for this
[07:42:31] <lifeless> which is largely a fungi thing
[07:42:52] <lifeless> basically they are all important
[07:51:42] <tchaypo> oh, it just clicked that you’ve made one card for each tool that needs work
[07:52:27] <tchaypo> I don’t see a devstack card; is this being tracked on one of the other cards?
[07:53:58] <tchaypo> “my WIP patch for using constraints files” would be https://review.openstack.org/#/c/189934/
[07:54:51] <lifeless> yes
[07:58:48] <tchaypo> “my in-progress upper-constraints review” is probably https://review.openstack.org/#/c/189251/ not https://review.openstack.org/#/c/189249/
[08:00:34] <lifeless> 251 yes
[15:28:15] <lifeless> dstufft: hi; I'm askeep but https://github.com/pypa/pip/pull/2917 fixes the issue found with -c in the wild.
[15:29:25] <dstufft> lifeless: sleep contributing? :D
[19:39:00] <lifeless> dstufft: child-woken was returning to bed
[19:39:11] <dstufft> lifeless: :)
[19:41:08] <lifeless> dstufft: so cool. Now I will pester you about what you need to do 7.1:)