Log file Viewer

[11:36:19] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[11:36:19] <pmxbot> Simplify implementation of Requirement.parse.

[11:54:42] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[11:54:42] <pmxbot> Extract _requirement_spec method for rendering the requirement specification for scripts. Ref #439.

[11:59:32] <jaraco> Hi ronny.

[12:00:15] <ronny> hi jaraco

[12:00:54] <ronny> jaraco: the commit you just pushed to setuptools is directly contrary to the pull request i openend for doing that ^^

[12:02:01] <jaraco> I understand it conflicts, but it’s not contrary - just a different approach.

[12:02:22] <jaraco> https://bitbucket.org/pypa/setuptools/pull-requests/149/develop-command-no-longer-pin-own-versions/diff#comment-10267076

[12:03:49] <ronny> jaraco: thing is the call paths for the script wrter, i was thinking of a diamond first, but thee also si the windows writer

[12:04:37] <ronny> jaraco: develop invokes easy install script writing invokes scriptwriter

[12:05:08] <ronny> if we need to override the scriptwriter class at easy_install invocations, the whole thing becomes more compicated

[12:05:39] <ronny> jaraco: i suspect there is need for some basic brainstorming

[12:06:39] <jaraco> I hadn’t thought about it too much - I thought my changes were equivalent to yours. If they’re not, then you’re right - some brainstorming is needed.

[12:09:33] <jaraco> Well, I see one mistake already.

[12:09:59] <ronny> in your code or in mine ?

[12:10:35] <jaraco> Mine. Yes - I meant to be changing the ScriptWriter, not easy_install.

[12:10:54] <jaraco> And so an override in develop doesn’t even make sense.

[12:11:28] <pmxbot> jaraco pushed 1 commit to setuptools (https://bitbucket.org/pypa/setuptools/) :

[12:11:28] <pmxbot> Backed out changeset 38b415c244b8

[12:12:33] <jaraco> That also explains why I thought it would conflict but did not.

[12:13:58] <ronny> due to personal constraints i also cant write tests for my own cahnge before nexxt weekend, today is allocated for py.test and my gf

[12:17:27] <jaraco> no problem. I need to punt on it too. Thanks for catching that mistake.

[12:18:51] <jaraco> !m ronny

[12:18:52] <pmxbot> you're doing good work, ronny!