PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Thursday the 19th of November, 2015

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[09:28:57] <ronny> dstufft, xafer: i'd like to help doing issue grooming for pip
[09:38:29] <xafer> well any help is welcome :) There are certainly +100 obsolete issues to encover ;)
[09:55:58] <ronny> xafer: but currently i lack the perms
[10:11:31] <xafer> well, I'll leave the perm issue to dstufft but for example, going through the 100+ open issues that were not updated in the last 12 months and reviewing them to check if they are still relevant does not require any perm :)
[10:13:46] <xafer> yes, I know how tempting it looks ;)
[10:24:15] <ronny> xafer: true, but im also unable to close them in such cases
[10:25:50] <xafer> well the hard work is not the close button, it's the explanation that will be posted on the issue
[10:26:11] <ronny> oh, i see what you mean
[10:26:24] <ronny> xafer: i suppose i can post uou close candidates after the explanation
[10:26:54] <xafer> that would be the idea :)
[16:28:32] <dstufft> nlh: https://github.com/pypa/warehouse/pull/751
[16:30:25] <nlh> dstufft: hooray!!
[16:30:55] <nlh> dstufft: can you also make sure that the issues on my repo are transferred over? And tag them with 'design'
[16:31:02] <dstufft> nlh: will do
[16:31:13] <dstufft> I have a NOTES file with issues to open as well
[16:31:24] <nlh> cool
[16:31:46] <nlh> Let me know once you're done at your end because I will probably want to setup some new issues for myself
[16:31:51] <dstufft> nlh: I wouldn't delete your repo fyi (incase you were planning on it), just incase I messed up a port or something
[16:32:22] <nlh> no, i will keep it there for posterity :)
[16:33:33] <dstufft> nlh: I forget if I told you, but once that's merged feel free to make PRs (and merge them yourself too!) and change whatever you want. it'll get auto deployed to warehouse-staging.python.org (but you might need to purge the Fastly cache, just do curl -XPURGE https://warehouse-staging.python.org/url/you/want/to/purge/)
[16:34:09] <dstufft> nlh: you don't have to get my OK to merge Python changes or anything, but if you want a review or something just CC me (I'll probably review them after the fact too, but calling me out will make me look faster)
[16:34:46] <nlh> ok - I think I've probably got enough on my plate with the front end without looking into the Python - so I'll probably just ping you if I need something done :D
[16:35:26] <nlh> also - is the cache purging documented somewhere? That might be helpful for future reference...
[16:35:27] <dstufft> nlh: works for me :) Just mentioning it incase you wanted to tweak something or whatever (I had to do a little bit of that)
[16:35:30] <dstufft> um
[16:35:32] <dstufft> I don't think so
[16:35:35] <dstufft> I probably should
[16:35:48] <nlh> yes please ;D Otherwise i will have to look up IRC logs ;)
[16:35:54] <dstufft> added it to my TODO
[16:35:56] <nlh> thanks
[16:37:50] <dstufft> nlh: Oh, fwiw changes to pypi-theme (the private repo) won't get deployed automatically. Right now that probably requires me to handle deploying a new version of that. I'll try to make it do something better though
[16:38:11] <dstufft> that'll be just stuff that is PyPI specific (Logo, the sponsors area, etc)
[16:38:26] <dstufft> or rather, just stuff that we don't have a license to distribute other than for PyPI itself
[16:38:30] <nlh> ok, cool. You might have noticed that I tried to split out the CSS for these areas too...
[16:38:52] <nlh> though I'm not finished
[16:39:00] <nlh> in case you want to serve a different css file...
[16:39:35] <dstufft> I'm not sure we need to serve a different CSS file (though maybe we do, idk). I'm not really worried about the use case of people other than PyPI using Warehouse
[16:39:47] <nlh> ok
[16:39:55] <dstufft> I'd just inline everything in th emain repo except Van asked us to keep it private for the stuff that can't be licensed Apache 2
[16:39:58] <nlh> well, it made sense to split it out anyway, so no skin off my nose
[16:40:23] <nlh> yes, that makes sense
[16:40:35] <nlh> oh - I wanted to bring up the logo again...
[16:40:46] <nlh> I was thinking about doing a variation...
[16:40:54] <nlh> where the logo was broken on the 404 page
[16:41:25] <nlh> Also, I was thinking we could have a cute talking cube as a help point...
[16:42:15] <nlh> daniel (our lead writer) has proposed a design for the help page where we have a series of questions that link off to PYPUG
[16:42:29] <nlh> i was thinking they could be speech bubbles from a talking block
[16:42:31] <nlh> lol
[16:42:33] <nlh> maybe
[16:42:38] <nlh> if it doesn't look too tacky
[16:43:11] <nlh> but obviously, I don't want to make variations of the logo if it's going to be a problem
[16:44:01] <dstufft> nlh: I can ask Van, I don't know the answer to how much trouble it would be :)
[16:44:18] <nlh> ok.. it's just an idea for now, so no problems if it isn't going to fly
[16:45:04] <nlh> and if it is going to require any kind of lawyering, then again, don't worry about it...
[16:45:13] <nlh> It's not super important, just an idea
[16:46:03] <dstufft> I can poke him privately and see what his feelings are
[16:46:05] <dstufft> bleh
[16:46:09] <dstufft> I broke heorku
[17:02:45] <dstufft> nlh: https://warehouse-staging.python.org/
[17:03:48] <nlh> dstufft: cool!!
[17:15:06] <dstufft> nlh: oh, I have a auestion
[17:15:09] <dstufft> question
[17:15:10] <nlh> yeah
[17:17:08] <dstufft> nlh: https://github.com/nlhkabu/warehouse-ui/blob/gh-pages/_includes/home-header.html vs https://github.com/nlhkabu/warehouse-ui/blob/gh-pages/_includes/header.html I'm trying to figure out the sanest way to merge those into a single template that just uses conditionals to hide/show the differences, the mobile-search thing is a simple if, but the top of header.html has an extra split-layout div and I'm trying to figure out if that was a
[17:17:09] <dstufft> mistake or if it needs two of them nested?
[17:19:20] <nlh> currently it needs two of them nested
[17:19:31] <dstufft> ok
[17:20:42] <nlh> so you have a floated layout inside a floated layout... like this: [[icon] [search]][menu]
[17:20:52] <nlh> so it's the same pattern applied on different levels
[17:20:57] <dstufft> gotcha
[17:21:08] <dstufft> I can make that happen
[17:21:19] <dstufft> copying over your issues and then going through my TODO
[17:23:11] <dstufft> okay, there are your four issues :D
[17:23:33] <nlh> thank-you! :D
[17:26:28] <dstufft> nlh: unless you'd rather keep it local to the less trafficed warehouse-staging.python.org, once I clear out some of my TODOs I'll deploy this to warehouse.python.org too
[17:26:58] <nlh> go ahead. Early feedback is always good! :D
[17:27:21] <dstufft> I guess maybe we should add the feedback widget too
[17:27:28] <dstufft> do you have one you'd prefer?
[17:38:08] <nlh> um....
[17:41:37] <nlh> http://www.getaninsight.com/
[17:41:39] <nlh> maybe...
[17:42:10] <nlh> assuming we can style it...
[17:42:16] <nlh> perhaps? I really don't know...
[17:42:30] <nlh> I want something really simple, where we can set custom questions...
[17:42:55] <nlh> if there is nothing on the market that we like, then we can always just create a tab that links off to a Google Form...
[17:45:29] <nlh> I'm not sure what the business model is for getaninsight... they don't charge anything... so are they making money off the collected data?
[17:48:09] <nlh> mmm... it's not responsive... which is a problem, because I'd really like to get feedback from mobile users
[19:12:58] <lifeless> dstufft: so is today the day ?
[19:13:27] <dstufft> lifeless: should be yes, sorry :) porting the new design over took longer than I expected
[19:14:41] <lifeless> dstufft: it would be awesome to get both acked