PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Wednesday the 13th of April, 2016

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[06:41:40] <warner> dstufft: I added some notes to https://github.com/pypa/pip/pull/3176
[06:42:17] <warner> (the one that changes 'pip install .' to make+unpack an sdist instead of copying the whole directory)
[06:43:23] <warner> the updated patch sort of works, but it omits setup.py from the generated sdist tarball, probably because it doesn't actually run "setup.py sdist".. instead of "setup.py" it's got that big shim that injects setuptools into distutils-only files
[06:44:18] <warner> so sys.argv[0] isn't a real file, so distutils.command.sdist.add_defaults() doesn't know that setup.py is a real thing, so it doesn't get added to the MANIFEST, and nobody includes setup.py in their MANIFEST.in (since it's usually automatic)
[20:37:48] <warner> hm, should pip pull-requests be based upon "develop", or against "master"?
[20:39:07] <warner> ah, found it, https://pip.pypa.io/en/stable/development/#pull-requests