pmxbot IRC Log Viewer

[14:23:35] <toad_polo> Anyone know the best way to invoke just the distutils test suite on CPython?

[14:28:51] <dstufft> uhh

[14:29:04] <dstufft> I think you can just execute the test_distutils or w/e?

[14:31:20] <toad_polo> The way I did it was ./python -m test -v test_dateutils

[14:31:27] <toad_polo> Er

[14:31:28] <toad_polo> test_distutils

[14:34:36] <toad_polo> Is it preferable to put Author: UNKNOWN or to omit the Author line entirely?

[14:34:48] <toad_polo> Same question RE: "Maintainer:"

[14:35:44] <toad_polo> The way I originally wrote this patch the logic is that at least one of Author or Maintainer will show up in the PKG-INFO, even if both are left blank.

[14:37:11] <toad_polo> I could just automatically populate it with UNKNOWN for both, though.

[14:39:26] <dstufft> I hate the fact distutils populates things with UNKNOWN

[14:39:33] <dstufft> I'd much rather it just omit'd them

[14:39:55] <dstufft> the reason it does the UNKNOWN thing is because some fields are "mandatory" in the spec

[14:39:56] <toad_polo> Well, that makes things easier.

[14:40:04] <dstufft> but I guess distutils didn't want to make them actually mandatory in the setup() call?

[14:40:31] <dstufft> I don't know why exactly it does that, but Warehouse just strips UNKNOWNs from most or all fields before processing the upload

[14:43:08] <toad_polo> All the Author/Maintainer stuff is not mandatory.

[14:44:04] <dstufft> cool

[14:44:07] <dstufft> just omit it then

[14:44:29] <dstufft> I suspect as soon as distutils and setuptools is setting the metadata and sending it along, Warehouse will just work

[16:25:04] <toad_polo> Harrumph: https://github.com/python/cpython/pull/6106

[16:25:15] <toad_polo> I didn't realize that distutils doesn't even support Metadata version 1.2

[16:25:45] <toad_polo> Does distutils really need to be able to support writing any version of the metadata?

[16:39:57] <toad_polo> Hm, maybe I should drop this whole thing in distutils, it seems like it would require a lot to support even version 1.2.

[16:50:11] <toad_polo> Is there no function in setuptools that reads PKG-INFO?

[17:43:18] <sumanah> Hi lghampton

[17:43:25] <lghampton> Hi!

[17:43:34] <lghampton> sumanah: ^

[17:44:14] <sumanah> !logs

[17:44:14] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[17:44:53] <sumanah> toad_polo: you asked, "Is there no function in setuptools that reads PKG-INFO?" Not sure; maybe ask on https://groups.google.com/forum/#!forum/pypa-dev ?

[17:44:58] <sumanah> lghampton: what are you working on?

[17:45:25] <lghampton> sumanah: I am leaving a comment on my PR

[17:45:28] <sumanah> great

[17:46:00] <lghampton> sumanah: I had some linter issues with the CSS but they are fixed now

[17:46:08] <sumanah> good :)

[17:48:16] <sumanah> Hiya waseem18, how's it going?

[17:48:41] <waseem18> Good morning Sumanah :)

[17:48:51] <waseem18> I'm looking into https://github.com/pypa/warehouse/issues/1299

[17:49:28] <waseem18> Right now making the side bar (filters) use markup

[17:50:34] <sumanah> Thanks waseem18! I bet the tree for trove classifiers will help nlh and a lot of the package maintainers out there

[17:51:26] <waseem18> Yeah :)

[17:51:59] <sumanah> lghampton: I need to get on another call in about 10 minutes, unfortunately, but you have a clear sense of what to do next?

[17:52:19] <lghampton> Yes, I am working on https://github.com/pypa/warehouse/issues/2649

[17:52:48] <lghampton> sumanah: enjoy your call :)

[17:54:12] <nlh> hi folks !

[17:54:23] <waseem18> Hi nlh :)

[18:02:00] <lghampton> nlh: hi!

[18:02:11] <lghampton> nlh: Thank you for your comments on my PR!

[18:04:16] <nlh> no problem lghampton :)

[18:39:04] <lghampton> !logs

[18:39:04] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[19:12:01] <sumanah> !logs

[19:12:01] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[19:22:06] <sumanah> lghampton: I'm done with my call. How are you doing? how's progress?

[19:22:54] <lghampton> sumanah: I am doing ok. I decided to start from the front end and get a form working so people could add classifiers

[19:23:34] <sumanah> lghampton: in the PyPI admin UI, right?

[19:23:47] <lghampton> I am making progress, I need to pass a `form` parameter to a view for it to work (hopefully)

[19:25:06] <lghampton> When I have gotten the form displayed I think I will push a PR so people can see it/comment

[19:26:13] <sumanah> lghampton: ok! Yeah a WIP branch and WIP PR is helpful :)

[19:26:51] <lghampton> sumanah: By admin UI you mean the pages that users can use to manage their projects?

[19:26:58] <sumanah> No, lghampton

[19:27:03] <sumanah> lghampton: ok, let me back up a moment

[19:27:15] <sumanah> so within PyPI, there are basically 4 classes of users

[19:27:20] <sumanah> 1: people who are not logged in at all

[19:27:45] <sumanah> 2: people who are logged in and aren't maintaining or owning any packages

[19:28:00] <sumanah> 3: logged-in people who are maintaining and/or owning packages

[19:28:09] <di_codes> ah, damn. not to discourage lghampton from working on this, but that’s exactly what i’ve been working on this morning (if we’re talking about <https://github.com/pypa/warehouse/issues/2649>)

[19:28:11] <sumanah> 4: PyPI admins, that is to say, Ernest, Donald, Dustin, etc.

[19:28:43] <sumanah> di_codes: you didn't see when I pinged you in IRC and in the issue to let you know Laura was working on that? :)

[19:28:53] <lghampton> sumanah: di_codes: I think Dustin will have made more progress with this

[19:29:07] <lghampton> sumanah: di_codes: I can choose another issue

[19:29:22] <di_codes> sumanah: sadly no, i was at lunch :slightly_smiling_face:

[19:29:49] <sumanah> di_codes: understood. lghampton if you push your work to a WIP branch now we can see how much overlap there is!

[19:29:56] <sumanah> this is a teachable moment

[19:30:39] <lghampton> sumanah: di_codes: There isn't much. I was trying to get the form to work, and was looking for the right view to pass a `form` parameter to

[19:30:48] <sumanah> ok

[19:31:06] <sumanah> lghampton: I think I'll ask you to review a few PRs

[19:31:11] <lghampton> sumanah: ok

[19:32:03] <sumanah> lghampton: https://github.com/pypa/warehouse/pull/3155

[19:32:15] <sumanah> "Send email when a new collaborator has been added to the project." by Mariatta

[19:32:40] <lghampton> sumanah: I see it, thank you!

[19:33:08] <sumanah> lghampton: and after that, https://github.com/pypa/warehouse/pull/2574 " simple/<package_name> sort versions correctly" by cryvate

[19:35:27] <di_codes> lghampton: real sorry to waste your time like that, I should have assigned the issue to myself

[19:35:28] <sumanah> lghampton: to finish up my explanation (which I'm about to go put in the architecture overview), when we talk about PyPI admins, or when you see the "admin" label/tag on an issue, we're talking about functionality for the fourth class of user

[19:35:56] <lghampton> sumanah: Ok, thank you

[19:36:42] <lghampton> sumanah: I looked at the tag on GitHub and thought it referred to type 3

[19:36:52] <sumanah> I'll update the label info.

[19:37:15] <sumanah> ah, it says "Features needed for the Admin UI (people running the site)"

[19:56:21] <nlh> sumanah, lghampton- just published: http://whoisnicoleharris.com/2018/03/13/user-testing-warehouse.html

[19:56:38] <lghampton> nlh: thank you!

[19:57:01] <sumanah> Wonderful!

[19:57:19] <nlh> lghampton, sumanah has already proof read - could you do a quick read over to make sure everything is ok before we make some noise about it?

[19:57:56] <lghampton> nlh: sure thing. I will take a look at it after I finish this PR.

[19:58:01] <sumanah> :)

[19:58:03] <nlh> \o/

[19:58:43] <nlh> thank you

[20:03:20] <sumanah> nlh: are you waiting on anything from me? if so it has slipped my mind

[20:04:02] <nlh> nope, I'm all good :) thanks for checking sumanah

[20:19:35] <sumanah> Hi illume

[20:20:22] <sumanah> illume: heads-up about https://github.com/pypa/warehouse/issues/3108 in case you want to subscribe to notifications on " Last-Modified header reported incorrect on file downloads #3108"

[20:20:26] <sumanah> since you reported it

[20:21:33] <sumanah> lghampton: once you finish reviewing cryvate's PR, I think it might be good for you to take over alanbato's https://github.com/pypa/warehouse/pull/2928 "Check if another file has been uploaded with the same blake2 digest"

[20:26:07] <lghampton> sumanah: I did cryvate's yesterday: https://github.com/pypa/warehouse/pull/3230

[20:26:40] <lghampton> I can take a look at alanbato's

[20:26:47] <sumanah> lghampton: perhaps you misunderstood

[20:27:06] <sumanah> lghampton: I asked you to please review https://github.com/pypa/warehouse/pull/2574 " simple/<package_name> sort versions correctly" which is a different PR by cryvate

[20:29:01] <lghampton> sumanah: oh, sorry, I just saw his name. I can take a look at it

[20:29:57] <sumanah> ok.

[20:30:17] <lghampton> nlh: I took a quick look at your post and it looks good! I would use m-dashes instead of n-dashes but that is picky :)

[20:32:47] <nlh> ah, yes, you're right lghampton, but I think that I am using n-dashes in other posts :(

[20:33:23] <lghampton> nlh: if it is your house style you can leave it as-is :)

[20:33:24] <sumanah> Your name starts with an N so why not N dashes?

[20:33:33] <sumanah> if there were S dashes maybe I would use those

[20:33:55] <sumanah> lghampton: once you're done looking at the simple sorting PR by cryvate, looks like #3155 is ready for re-review.

[20:34:01] <lghampton> sumanah: ok

[20:35:41] <dstufft> Using N-dashes because your name starts with N seems about as reasonable as a reason to use one over the other as I have ever been able to construct in my own head

[20:36:09] <dstufft> I'm sure there is like, an actual offiical reason you'd use one over the other

[20:36:39] <illume> @sumanah cheers.

[20:41:09] <nlh> hey dstufft - could you please amplify https://twitter.com/nlhkabu/status/973660123792068609 ?

[20:42:33] <nlh> thanks! :D

[20:42:53] <dstufft> Mark can probably get the psf to RT it

[20:42:59] <dstufft> they have much more reach than I do

[20:46:28] <sumanah> nlh: you're already sending it to the Open Design folks at Open Knowledge Foundation and the others we talked about?

[21:06:45] <nlh> sumanah, that's the plan for tomorrow :)

[21:06:53] <sumanah> :)

[21:14:27] <lghampton> sumanah: I think I am going to pack it in for today. I left a comment on cryvate's sorting Pr

[21:14:32] <lghampton> *PR

[21:14:32] <sumanah> Thanks lghampton!

[21:14:42] <sumanah> lghampton: yeah I saw that and Dustin's reply.

[21:14:48] <sumanah> lghampton: what is the rest of the week looking like for you?

[21:15:42] <lghampton> sumanah: I have a presentation that I need to give thursday evening, and I'd like to have some time to work on that. Do you want to get together remotely on Friday?

[21:15:57] <sumanah> lghampton: Yes, Friday. Thanks!

[21:16:57] <lghampton> sumanah: ok, see you then!

[21:17:52] <sumanah> thanks lghampton

Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Tuesday the 13th of March, 2018