PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Wednesday the 21st of March, 2018

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[02:20:06] <sumanah> https://groups.google.com/forum/#!topic/pypa-dev/w7IMrNiiEuQ weekly Warehouse report email is sent
[06:56:23] <pgadige__> hello! while working on the issue #3196(https://github.com/pypa/warehouse/issues/3196), I tried testing the required changes for 'Release Detail Page' in the chrome browser version 65.0, and I observed that the link underline appears discontinuous (screenshot: https://pasteboard.co/HcT2RpB.png). Is this something that is expected of the chrome browser? Is this normal to have discontinuous link
[06:56:29] <pgadige__> underline for a text containing either 'y' or 'g' or such letters? I'm glad I got to observe the subtle differences in the way links appear across different web browsers.
[06:56:50] <pgadige__> and oh the project in context is warehouse
[08:36:08] <agronholm> di_codes1: sorry I couldn't get the time to review the PR but I should have time today
[14:11:33] <di_codes1> pgadige__: yup, that is a characteristic that most browsers have these days
[14:11:48] <di_codes1> agronholm: no worries!
[15:06:57] <toad_polo> jaraco (or any other pypa admin): I don't seem to have privileges on the appveyor for setuptools.
[15:07:17] <toad_polo> I think I can tell what needs to be done based on this: https://www.appveyor.com/docs/team-setup/#understanding-relationship-between-github-team-and-appveyor-role
[15:07:57] <toad_polo> If we can add a "setuptools" team to the pypa app, with myself, jaraco and benoit-pierre on it.
[15:08:36] <toad_polo> Then someone logs in to appveyor as "pypa", click on the "setuptools" project, click on your username menu thing in the top right, click "Team"
[15:09:30] <toad_polo> Oh, maybe "setuptools developers" is already in the pypa teams.
[15:09:56] <toad_polo> So then just add a mapping between "Setuptools developers" and the Administrator role on appveyor.
[15:34:08] <sumanah> di_codes: https://github.com/pypa/warehouse/issues/869#issuecomment-340928703 - your checklist comment there. I think you should check that checkbox!
[15:35:27] <di_codes> sumanah: thanks! done.
[15:45:08] <sumanah> and di_codes just to be absolutely clear, I said in https://github.com/pypa/warehouse/issues/869#issuecomment-374425355 that we're leaving that issue open till the `wheel` fix is merged and released. You agree with that decision?
[15:46:58] <di_codes> sumanah: yes I agree!
[15:47:02] <sumanah> Awesome
[16:24:15] <sumanah> dstufft: I've opened a ticket about Warehouse having a proper support queue https://github.com/pypa/warehouse/issues/3231
[16:28:09] <dstufft> sumanah: I'll take soe poking around and see wha tI can find this evening
[16:28:44] <sumanah> Thanks dstufft
[16:29:04] <sumanah> dstufft: it's also ok to concentrate on pip stuff, I know pf_moore is trying to get that release out
[16:32:16] <sumanah> dstufft: ^ please do comment on https://github.com/pypa/warehouse/issues/3331 if I didn't capture what you were talking about
[16:32:40] <sumanah> in general dstufft you may have comments to make on https://github.com/pypa/warehouse/issues?q=is%3Aissue+is%3Aopen+label%3Aadmin the `admin` features
[16:50:49] <sumanah> di_codes: regarding https://github.com/pypa/warehouse/issues/3174 -- IIRC, you're hoping for more opinions from more folks to help you resolve this. If you have any folks in mind I can do the outreach; if you have *types* of folks in mind, I can maybe look in my network for some.
[16:51:53] <sumanah> di_codes1: regarding https://github.com/pypa/warehouse/issues/3174 -- IIRC, you're hoping for more opinions from more folks to help you resolve this. If you have any folks in mind I can do the outreach; if you have *types* of folks in mind, I can maybe look in my network for some.
[16:51:59] <sumanah> (CAPTCHA)
[17:08:44] <nlh> hi everyone :)
[17:08:57] <nlh> sumanah, you wanted to ask me something?
[17:09:02] <sumanah> Yes, hi nlh
[17:09:49] <sumanah> nlh: I wanted to check in about something dstufft and di_codes1 and EWDurbin and I were talking about yesterday, your nighttime, about the roadmap. Whether the issues in https://github.com/pypa/warehouse/milestone/7 warrant keeping legacy PyPI up
[17:10:30] <nlh> nope, I think these are all nice to haves
[17:10:45] <sumanah> nlh: hmmm. would you read https://github.com/pypa/warehouse/issues/1294 and double-check?
[17:11:18] <sumanah> I think the trove classifier work is a must have because people do depend on there being an all-on-one-page list of classifiers
[17:11:40] <sumanah> and then there's the file download regression and potentially accessibility issues
[17:12:25] <nlh> well, I think it depends how many people are using the trove classifier page currently
[17:12:30] <sumanah> nlh: and there are a few design questions in the milestone I want to extra-confirm about
[17:12:55] <alanbato> Hello everyone :)
[17:12:59] <sumanah> Hi alanbato!
[17:13:02] <nlh> hi alanbato!
[17:13:25] <nlh> but the trove classifier page should be fairly simple to do
[17:13:39] <sumanah> nlh: I know waseem18 is working on it
[17:14:01] <nlh> for the file download regression - I'll let other (more qualified folks) decide on that
[17:14:56] <alanbato> I'm in need of help. While working on the PR for #3151 (the legacy API docs) I ran into problems building the docs locally :(
[17:15:05] <nlh> sumanah, for the accessibility / design issues - I think it's fairly safe to say that the new design is *much* better on both these fronts. we obviously need to address these, but I don't think it makes sense for them to be blocking issues
[17:16:06] <sumanah> ok nlh so what this means is that I am going to move some issues out of "shut down legacy" and into the "post-shutdown" milestone, and the "shut down legacy" milestone will be solely for some administrative stuff
[17:16:36] <sumanah> plus the trove classifier which waseem18 is working on right now anyway
[17:16:53] <sumanah> alanbato: what errors are you getting?
[17:17:15] <nlh> sounds good sumanah :)
[17:17:34] <alanbato> I'm getting this error trying to run make docs:
[17:17:35] <alanbato> : *** The '/.state/env/bin/sphinx-build' command was not found. Make sure you have Sphinx installed, then set the SPHINXBUILD environment variable to point to the full path of the '/.state/env/bin/sphinx-build' executable. Alternatively you can add the directory with the executable to your PATH.
[17:17:59] <sumanah> alanbato: so have you already built your local dev env with `make serve`?
[17:18:10] <sumanah> `sphinx` running properly depends on the Docker container being up
[17:18:15] <sumanah> in my experience
[17:18:41] <sumanah> alanbato: so if you `make serve`, even if you then control-c out of that set of processes, then `make docs`, things will work
[17:18:52] <alanbato> Oh, that must be it. Let me check. For some reason I thought there wasn't a need for docker for that
[17:19:49] <sumanah> alanbato: and feel free to improve the docs on this if the guide wasn't clear
[17:20:54] <waseem18> Hi Sumanah - Work on building Trove classifier section with markup and styling has been completed - Here's the PR - https://github.com/pypa/warehouse/pull/3273
[17:22:01] <sumanah> thanks waseem18! and the related trove classifier issues?
[17:23:05] <waseem18> The issuues are related to styling the classifier section. The PR addresses the styling part too.
[17:24:21] <waseem18> I've put some screenshots on the PR on how the trove classifier section would look like.
[17:26:47] <sumanah> nlh: in our Monday meeting https://wiki.python.org/psf/PackagingWG/2018-03-19-Warehouse you mentioned that "3149" was a must-have --- is this something in a different repo?
[17:34:48] <alanbato> Btw sumanah, here's a preview what I'm doing to improve the docs on the legacy API. I'd like to know your opinion on it :) https://dpaste.de/gmBd
[17:35:16] <sumanah> I like the format, alanbato!
[17:35:27] <sumanah> I really like "example value"
[17:36:15] <sumanah> alanbato: https://packaging.python.org/specifications/core-metadata/#description-content-type-optional the package description can actually be in md, rst, or plain text!
[17:36:28] <alanbato> Originally I put the Core Metadata Specification field name too, but figured it would cause confusion
[17:36:51] <sumanah> alanbato: I actually think a separate column with the core metadata spec fieldname would be great
[17:36:55] <sumanah> people will want to match them up
[17:37:18] <sumanah> I can imagine already the dozens of people who will be glad to know how description and long_description fit together
[17:38:21] <alanbato> Thanks for the pointer. There's still several fields missing, but I'm not sure if all are relevant
[17:39:23] <alanbato> Like the dependency and file information, for example. Should I add them all? In the form there are "legacy dependency information" and "newer dependency information"
[17:41:33] <alanbato> sumanah: I'm not sure what you mean by description and long_description, do you mean summary and description?
[17:42:02] <sumanah> alanbato: I'd love for you to ask these questions in the GitHub issue actually, so Dustin and others can answer them.
[17:42:25] <sumanah> (sorry, "long_description" is the setup.py name for a package description)
[17:42:43] <sumanah> (and yeah, summary versus description is also a useful distinction people need to make)
[17:43:38] <alanbato> Good idea, will do. If you have any other pointer they're more than welcome :)
[17:45:23] <alanbato> sumanah: Oh, I have one more question, the 79 character limit still holds in the docs, right? That's why I couldn't fit that extra column earlier
[17:46:35] <sumanah> alanbato: huh, I think there's a way around that if you use Sphinx/reStructuredText's console markup
[17:47:00] <sumanah> I don't know the details, sorry, but I think I've seen our linter be ok with longer lines with certain directives or something
[17:48:35] <alanbato> sumanah: Alright, I'll look it up then. I'm writing the q's in the issue right now, if you want to chime in after I post the comment
[17:48:47] <alanbato> sumanah: Thanks a lot!
[17:48:56] <sumanah> Glad to help -- and very glad to have your help on this alanbato
[17:49:07] <sumanah> you're better at this than I could be because you're more familiar with forklift
[17:52:22] <alanbato> sumanah: I think it's more like a distant relative you only see during the holidays, haha. But I do plan to get familiar with more parts of the codebase and do everything I can to help with Warehouse :)
[17:52:31] <sumanah> :) thanks alanbato