PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Tuesday the 12th of February, 2019

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[12:42:10] <nicolasbock> Hi. I found that pip isn't very good dealing with IPv6 addresses. In particular if pip gets a --constraint via http and starts following links in that file, the URL clean function quotes the brackets of the IPv6 address itself, which is incorrect. I have uploaded a patch (https://github.com/pypa/pip/pull/6245) which fixes this issues. But this is the first time I am submitting a patch to pip and I am not sure if the way
[12:42:11] <nicolasbock> I wrote it is acceptable. Please let me know if something is missing or if I should change anything in terms of the implementation. Thanks!
[12:42:34] <nicolasbock> StevenK: ^^
[12:50:57] <StevenK> nicolasbock: Overlong lines causes Travis failure, but it looks great to me
[12:51:11] <StevenK> dstufft: ^ What do you think? (Also, hi! It's a been a while)
[12:51:25] <nicolasbock> Thanks! I didn't want to wrap the backtrace for readability
[12:51:42] <nicolasbock> I could if Travis has issues. I always like to make Travis happy ;)
[12:52:59] <StevenK> nicolasbock: It's the lint job, not the test suite -- ./tests/unit/test_url.py:10:80: E501 line too long (81 > 79 characters)
[12:53:28] <nicolasbock> Oops, yes
[12:53:34] <nicolasbock> Let me fix