Log file Viewer

[14:45:01] <woodruffw> hey di_codes, EWDurbin: any idea why this test would fail on the TOTP PR: https://travis-ci.org/pypa/warehouse/jobs/506026513#L1170

[14:46:12] <woodruffw> it looks like the missing item is the global.login rate limiter, but i don't currently see the connection between that and the changes

[14:47:23] <EWDurbin> Taking a look.

[14:50:26] <EWDurbin> woodruffw: I think it’s because you are registering this new service factory: https://github.com/pypa/warehouse/pull/5567/files#diff-5c245f2d94f93b79afdade0195322759R128

[14:50:50] <EWDurbin> Try adding a stub/pretend at https://github.com/pypa/warehouse/blob/master/tests/unit/accounts/test_core.py#L288

[14:51:17] <woodruffw> thanks! i'll try that now

[14:51:17] <EWDurbin> Errr you need to add it at https://github.com/pypa/warehouse/blob/master/tests/unit/accounts/test_core.py#L275

[14:51:44] <EWDurbin> Yeah updating that stub and the assertion should make you right

[14:56:08] <woodruffw> EWDurbin: that seems to have done the trick locally! much appreciated :-)

[15:40:22] <sumanah> I'm doing a little bug triaging

[15:40:32] <sumanah> EWDurbin: https://github.com/pypa/warehouse/issues/5286 ought to be transferred to the pip repo?

[15:41:22] <sumanah> pradyunsg: di_codes: https://github.com/pypa/warehouse/issues/5247 could definitely use your voice ("Roadmap update for TUF support")