Log file Viewer

[04:59:47] <sayanarijit> !logs

[04:59:47] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[15:36:54] <a_rog> hi everyone i was wondering if this is the right place to look for help with a pull request ?

[15:45:42] <sumanah> Hi a_rog -- a pull request with which project?

[15:46:06] <a_rog> pypa/pip

[15:46:45] <sumanah> a_rog: then yes!

[15:48:11] <a_rog> Great, I am just wondering if there was anything i was meant to do to forward on https://github.com/pypa/pip/pull/6650 I have never done a PR before so i was worried i am missing something obvious

[15:49:27] <sumanah> congrats on your first PR a_rog! looking now

[15:49:40] <sumanah> ping pradyunsg

[15:50:25] <sumanah> a_rog: unclear to me as well. You did the right thing, asking in a comment on GitHub and asking here

[15:52:47] <sumanah> a_rog: I think the maintainers haven't been clear enough in their comments on the issue and they will reply there to say either that one more maintainer needs to review and approve the PR, or that it's fine now, or they'll specify a thing you need to improve

[15:53:03] <a_rog> ok no worries ,I can just wait on it. I was more worried i was missing something, Appreciate the help and enjoy your weekend.

[15:53:15] <sumanah> a_rog: want a suggestion for another small issue to start on?

[15:53:50] <a_rog> @sumanah sure

[15:57:25] <sumanah> a_rog: take a look at https://github.com/pypa/setuptools/issues/1565 ?

[16:00:04] <a_rog> sumanah Thanks

[16:00:14] <sumanah> thank you!

[16:01:27] <pradyunsg> a_rog: that PR is good to go. I actually was walking to office, when I approved it. I didn't press the other button because I'd reached. I'll merge it when I get near a PC. :)

[16:01:43] <pradyunsg> Thanks for the ping sumanah! :D

[16:01:58] <sumanah> :)

[16:02:42] <pradyunsg> a_rog: Sorry for the confusion on it. 🙆🏻‍♂️

[16:04:01] <a_rog> @pra

[16:04:50] <a_rog> @pradyunsg no worries its a tiny patch i appreciate all the help thanks @sumanah as well

[16:10:33] <sumanah> :)