Log file Viewer

[00:08:19] <sumanah> techalchemy: ping in case you got distracted :-)

[00:08:44] <techalchemy> yes there are at least 2, just putting documentation together

[00:10:28] <sumanah> techalchemy: cool! thanks

[00:20:46] <techalchemy> ok yeah

[00:20:48] <techalchemy> i think that's good

[00:21:32] <sumanah> techalchemy: ok. refresh https://github.com/pypa/pipenv/issues/3369 ?

[00:25:22] <techalchemy> sumanah, seems right

[00:25:44] <techalchemy> bearing in mind I haven't spent a lot of time on pipenv itself, it doesn't seem that far off at least

[00:25:48] <sumanah> techalchemy: great. Next, you mentioned: " i'll just diff the pipenv/vendor and pipenv/patched directories and see if it's all just updates in the recent one" did you have time to do that?

[00:25:59] <techalchemy> no but i'll do it right now it's quick

[00:26:23] <techalchemy> i'm trying to stay on task here even though i have fixes for the issues i filed just now :p

[00:27:58] <sumanah> techalchemy: :-) once you do that branch cleanup, then yeah, I think it is a good idea to commit the fixes to those requirementslib issues! then we can CHECK the CHECKBOXES which is exciting

[00:38:16] <sumanah> techalchemy: you set for the next ~15 min?

[01:07:59] <sumanah> techalchemy: how's the branch cleanup?

[01:09:20] <techalchemy> ah yeah i am reviewing some older ones

[01:10:00] <sumanah> cool

[01:15:11] <techalchemy> ok yeah i deleted the other vendoring branch and a few other stale ones

[01:15:20] <sumanah> cool! thanks techalchemy

[01:15:34] <sumanah> techalchemy: is now a good time to commit the fixes to those requirementslib issues?

[01:16:22] <techalchemy> no problem, i'll get those requirementslib changes up as a PR and such, hopefully the rest of this goes smoothly... I may need to cut a pip-shims release to build requirementslib let me check that

[01:17:08] <sumanah> cool

[01:19:04] <sumanah> I'll be back in 20 min

[01:52:10] <sumanah> techalchemy: how's it going?

[01:54:46] <techalchemy> sumanah, erm

[01:54:52] <techalchemy> same as always tbh

[01:54:55] <sumanah> :-)

[01:54:58] <techalchemy> trying to get my current branch committable

[01:55:05] <techalchemy> which could take years

[01:55:05] <techalchemy> :p

[01:55:45] <techalchemy> i'll move on

[01:57:36] <sumanah> Thanks techalchemy :-) which branch?

[01:57:45] <sumanah> I mean, what task are you working on?

[01:57:58] <techalchemy> requirementslib

[01:58:06] <sumanah> ah right

[01:58:19] <techalchemy> i just have a whole lot of new stuff that breaks in a strange way i can't work out

[01:58:50] <sumanah> techalchemy: this might be something Tzu-Ping could advise on?

[01:59:28] <techalchemy> it could be, I think I just need some dedicated time on this one

[01:59:32] <techalchemy> maybe tomorrow!

[01:59:44] <techalchemy> i'm going to just get the actual changes up

[01:59:45] <sumanah> techalchemy: ok. So how about we do a few other things right now and then tomorrow you try to do requirementslib stuff

[01:59:51] <sumanah> ah ok, that sounds good

[02:04:47] <sumanah> if you would like, you could quickly review https://github.com/pypa/pipenv/pull/4145 which fixes the documentation links (although I am still waiting for tests to run)

[02:15:04] <techalchemy> sumanah, I will take a look, i need to eat however

[02:15:09] <sumanah> As do I!

[02:15:14] <sumanah> Thanks for your work today.

[02:15:15] <techalchemy> the prs I am trying to put together are not cooperating :|

[02:15:28] <techalchemy> thanks for all your help!

[02:15:31] <techalchemy> have a good night

[02:18:08] <sumanah> Night!

[17:59:15] <travis-ci> pypa/pip#15028 (master - 3487df5 : Pradyun Gedam): The build passed.

[17:59:15] <travis-ci> Change view : https://github.com/pypa/pip/compare/60d640276a96...3487df553f57

[17:59:15] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/659262485

[18:13:41] <sumanah> techalchemy: I'm on and off IRC today but do you need any help/directions?

[18:19:06] <techalchemy> i'm good thanks sumanah working on the things we discussed

[18:19:11] <sumanah> cool :)

[20:52:30] <sumanah> techalchemy: I think the build failures on https://github.com/pypa/pipenv/pull/4145 are transient so I just pushed the branch again

[20:52:48] <techalchemy> sumanah, don't worry too much about it, I'll be surprised if tests pass

[20:52:52] <techalchemy> thanks for the pr

[20:53:02] <sumanah> ah ok. thanks techalchemy

[22:11:07] <travis-ci> pypa/pip#15032 (master - 3487df5 : Pradyun Gedam): The build passed.

[22:11:07] <travis-ci> Change view : https://github.com/pypa/pip/compare/2c0d6918934a9bc01612ade569ef7f58d40a54f6...3487df553f5732455433b1dd63be6a1a48ba9d72

[22:11:07] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/659345476

[22:13:50] <travis-ci> pypa/twine#1321 (master - fb03835 : Brian Rutledge): The build passed.

[22:13:50] <travis-ci> Change view : https://github.com/pypa/twine/compare/613a6f641fdefb815f6ad9cd20ee98220c5529c5...fb03835ebf124ed2f9a447a5f0bd607c283172fb

[22:13:50] <travis-ci> Build details : https://travis-ci.org/pypa/twine/builds/659354376