pmxbot IRC Log Viewer

[07:54:41] <gutsytechster> !logs

[07:54:41] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[07:55:10] <gutsytechster> pradyunsg: Ah! I got inactive yesterday.

[07:56:43] <gutsytechster> pradyunsg: When options.path is None, then "WorkingSet" is initialized with sys.path which is done inside the vendored package "pkg_resource".

[09:14:49] <siayush> Hello everynone, can anyone please give more info about issue #7699.

[09:15:39] <siayush> https://github.com/pypa/pip/issues/7699

[11:42:36] <pradyunsg> ssurbhi: o/

[11:43:38] <ssurbhi> Hey pradyunsg ! o

[11:44:43] <ssurbhi> s/o/o/

[11:46:37] <pradyunsg> You wanted to discuss the potential tasks for the GSoC 2020 projects, correct?

[11:47:25] <pradyunsg> Did you have a specific project in mind from the listed project ideas?

[11:49:14] <ssurbhi> Yeah. It's the one -- Improve pip's test helpers.

[11:52:36] <pradyunsg> Do you have any specific tasks in mind about it already?

[11:58:22] <ssurbhi> I have been working on this issue -- https://github.com/pypa/pip/issues/6050 and for now I am planning to complete this. Other than this I don't have any specific tasks in my mind right now.

[11:58:34] <pradyunsg> Ah okay.

[12:13:50] <pradyunsg> Broadly, without actually digging to check the myriad of issues, I can think of...

[12:13:53] <pradyunsg> 1. Move to `pathlib.Path` / `pathlib2.Path`

[12:13:53] <pradyunsg> 2. Update `virtualenv` fixture, for virtualenv 20.0+ compatibility

[12:13:53] <pradyunsg> - Goal: Fix test isolation for venv

[12:13:53] <pradyunsg> 3. Coverage reporting on pip's test suite

[12:13:53] <pradyunsg> - Start w/ unit tests

[12:13:53] <pradyunsg> - Proceed to non-unit tests

[12:13:53] <pradyunsg> - Goal: Coverage Reports

[12:13:54] <pradyunsg> 4. Break out all the code in `tests/lib/__init__.py`

[12:13:54] <pradyunsg> - Create more sub-packages in `tests.lib.*`

[12:13:55] <pradyunsg> - Goal: `tests/lib/__init__.py is empty`

[12:13:55] <pradyunsg> 5. Break up `conftest.py`

[12:13:56] <pradyunsg> - All fixtures defined in `tests.lib.fixtures` package

[12:14:09] <pradyunsg> - Goal: No fixtures defined directly in `conftest.py

[12:27:15] <ssurbhi> Okay, can you please elaborate the 4th a little. It's not clear to me. What are the sub-packages that would be required in `test.lib.*` ?

[12:33:47] <pradyunsg> ssurbhi: that

[12:34:20] <pradyunsg> ssurbhi: that has to be figured out — I’m not sure yet, since I’ve not taken a closer look.

[12:37:18] <ssurbhi> oh okay. Thank you so much. :)

[15:12:47] <travis-ci> pypa/pip#15164 (master - 104b665 : Paul Moore): The build passed.

[15:12:48] <travis-ci> Change view : https://github.com/pypa/pip/compare/9e15cd49f24b...104b6650c870

[15:12:48] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/664426115

[16:40:10] <gutsytechster> !logs

[16:40:10] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[16:41:15] <pradyunsg> Adetomi: whenever you join again, go ahead and file a PR for that change. I suggest not adding new headings and removing "parallel" / "sequential" references.

[16:41:40] <gutsytechster> pradyunsg: o/

[16:41:51] <pradyunsg> gutsytechster: o/

[16:43:21] <gutsytechster> pradyunsg: Can you have a look on my above query?

[16:43:29] <pradyunsg> gutsytechster: do you still have concerns, reg https://github.com/pypa/pip/pull/7810#issuecomment-599191405?

[16:43:35] <gutsytechster> When options.path is None, then "WorkingSet" is initialized with sys.path which is done inside the vendored package "pkg_resource".

[16:44:48] <pradyunsg> gutsytechster: not sure what your doubt is...

[16:45:32] <pradyunsg> When options.path is None, it [pkg_resources] uses sys.path - which is what we're using [in the suggested approach], except skipping "" in it, which represents the current directory.

[16:45:36] <pradyunsg> gutsytechster: ^

[16:46:18] <gutsytechster> pradyunsg: In suggested approach, we are traversing through options.path?

[16:46:27] <pradyunsg> No.

[16:46:54] <gutsytechster> Oh ok. Got it

[16:46:59] <pradyunsg> :)

[16:47:48] <gutsytechster> But, also when we invoke pip using "python -m", apart from "", a absolute path to current directory is also added in sys.path

[16:48:28] <gutsytechster> Even if we skip "", it still show up the package present in the current directory.

[16:49:22] <pradyunsg> gutsytechster: As per my understanding, no, an absolute path to CWD (current working directory) is not added by `python -m`. Go ahead and try it out?

[16:49:36] <gutsytechster> But I've seen this within "freeze" command and "get_installed_distribution" methods.

[16:50:02] <gutsytechster> Though within "WorkingSet", it just show a ""

[16:50:28] <gutsytechster> pradyunsg: I tried. :)

[16:50:29] <pradyunsg> You can check what’s in `sys.path` by adding a line `import sys; print(sys.path)` in `pip.__main__`.

[16:50:34] <pradyunsg> :)

[16:51:00] <pradyunsg> Hmm… I’m not sure I follow what you’re saying.

[16:51:22] <gutsytechster> Oh!, I used a print statement within "freeze" command and then run the command. When control goes over that print statement, I found what is in sys.path.

[16:51:40] <pradyunsg> That’ll do too.

[16:52:05] <pradyunsg> What we want to do here, is to make sure that the call to `get_installed_distributions` does not get the CWD.

[16:52:31] <gutsytechster> Well, using that. I see that both "" and an absolute path to CWD in sys.path.

[16:52:43] <pradyunsg> What’s your CWD?

[16:52:43] <gutsytechster> pradyunsg: But what if CWD is supposed to be there?

[16:53:05] <gutsytechster> just a sec

[16:53:40] <gutsytechster> pradyunsg: "/home/gutsytechster/Documents/Projects/Open-Source-Projects/pip" is my CWD

[16:54:16] <gutsytechster> This is root pip directory.

[16:54:51] <pradyunsg> And what’s the result of `python -c "import sys; print(sys.path)"`?

[16:56:30] <pradyunsg> gutsytechster: ^

[16:56:39] <gutsytechster> pradyunsg: https://paste.centos.org/view/4096b807

[16:56:40] <gutsytechster> here

[17:00:54] <gutsytechster> pradyunsg: I write the statement print(sys.path) within `pip.__main__` and when I ran `python -m pip freeze`, this is what I've got https://paste.centos.org/view/4d481646

[17:01:43] <pradyunsg> gutsytechster: Did you install pip with `pip install -e .`?

[17:02:05] <gutsytechster> pradyunsg: I installed pip using `pip install .`, without -e option

[17:02:13] <pradyunsg> :/

[17:02:35] <gutsytechster> Someone suggested to install it like this on a issue.

[17:03:35] <pradyunsg> AdeTomi: take a look at the logs; and at https://github.com/pypa/pip/issues/7699 or https://github.com/pypa/pip/issues/7731.

[17:03:39] <pradyunsg> !logs

[17:03:39] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev

[17:03:54] <pradyunsg> gutsytechster: taking a look at the issue now.

[17:06:30] <gutsytechster> pradyunsg: I also want to contribute to `pip` as a GSoC student. Can you help me out picking up tasks.

[17:06:40] <gutsytechster> I am really enjoying contributing to it.

[17:07:18] <gutsytechster> :)

[17:10:02] <pradyunsg> gutsytechster: :)

[17:11:02] <pradyunsg> gutsytechster: Do you have a not-listed project idea in mind?

[17:11:17] <gutsytechster> pradyunsg: I have seen a list of tasks in the Ideas page. Apart from it, I was thinking of adding tasks like adding test coverage

[17:11:33] <pradyunsg> I suggest you start by trying to explore how pip’s tests work, to get a better understanding of the area that you’d have to work on then.

[17:11:47] <pradyunsg> Lemme see if there’s any low hanging fruit there.

[17:12:22] <gutsytechster> pradyunsg: I am just diving into the source code. I was interested in Improving pip's test helper though

[17:12:45] <pradyunsg> :)

[17:13:09] <pradyunsg> Take a look at tests/lib then; and try to understand what the various bits are.

[17:14:54] <pradyunsg> ~5 hours ago, I listed a bunch of potential tasks, a random set of things that would improve those helpers.

[17:14:55] <gutsytechster> pradyunsg: ok. I'll look through them and would let you know.

[17:15:13] <gutsytechster> Ah! I haven't seen the logs yet.

[17:15:20] <gutsytechster> Let me have a look at it.

[17:16:21] <gutsytechster> Thanks.

[17:16:36] <pradyunsg> Ideally, you’d spend time to understand enough what those changes mean and why they’d be useful. /cc @ssurbhi

[22:20:48] <travis-ci> pypa/twine#1337 (master - f7402e0 : Brian Rutledge): The build passed.

[22:20:48] <travis-ci> Change view : https://github.com/pypa/twine/compare/5482d6877df0cd90545c4708e5abe13b359f8a08...f7402e0d2e1c1e6ecde61dc8bcba515b807a48a0

[22:20:48] <travis-ci> Build details : https://travis-ci.org/pypa/twine/builds/664619519

[22:22:57] <travis-ci> pypa/pip#15170 (master - 104b665 : Paul Moore): The build passed.

[22:22:57] <travis-ci> Change view : https://github.com/pypa/pip/compare/ffe553638c035292e17657cbacbfb48e189a9221...104b6650c870083dfcd9171776cd92e81a6383c5

[22:22:57] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/664612887

Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Thursday the 19th of March, 2020