PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Saturday the 28th of March, 2020

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[01:02:58] <travis-ci> pypa/pip#15285 (master - e1e5588 : Pradyun Gedam): The build passed.
[01:02:58] <travis-ci> Change view : https://github.com/pypa/pip/compare/4e81af49eb24...e1e558835c33
[01:02:58] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/667937028
[06:09:58] <McSinyx[m]> goodnight everyone!
[06:22:56] <McSinyx[m]> oh no I put my computer to sleep too early
[06:29:21] <McSinyx[m]> sumanah: ``an Official Letter from an Official Person saying that you have special authorization to stay up late'' sounds amazing (-; although my parents are ok if I asked them first (i.e. the other night my dad wasn't fully awake hence got confused and mad), but generally they won't allow it for more than a few days
[06:30:12] <McSinyx[m]> techalchemy: I feel you, just spent 10 minutes to load github
[06:31:03] <McSinyx[m]> normally it's not even slow, but sometimes there's absolutely no connection anywhere (8.8.8.8 still pingable tho)
[12:14:43] <travis-ci> pypa/pip#15290 (master - 4381493 : Paul Moore): The build passed.
[12:14:43] <travis-ci> Change view : https://github.com/pypa/pip/compare/e1e558835c33...4381493c5289
[12:14:43] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/668033265
[13:21:37] <pradyunsg> techalchemy: yea, you're on Debian. You deserve that prompt. 😂
[13:22:26] <pradyunsg> Just kidding, we figured that adding back those endpoints and making it loudly warn the user would be a good thing to do, since a *lot* of traffic on our issue tracker was to that issue of broken wrappers.
[13:24:38] <pradyunsg> devesh: yea, there's something weird happening with Travis CI, at least with pip's CI, but I don't know if there's anything we can do to fix it at this point, since the issues are more "platform is not doing the right thing" vs "change some lines in file" for us as an end user of their service.
[13:59:03] <travis-ci> pypa/pip#15294 (master - 326efa5 : Devesh Kumar Singh): The build passed.
[13:59:03] <travis-ci> Change view : https://github.com/pypa/pip/compare/4381493c5289...326efa5c710e
[13:59:03] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/668071125
[14:26:32] <devesh> pradyunsg: So that means something is wrong on azure's side
[14:52:08] <pradyunsg> Travis CI's side, yea.
[14:57:38] <McSinyx[m]> pradyunsg: about a month ago azure was failing for no reason too, not sure the same thing is happening to devesh
[15:00:40] <McSinyx[m]> pradyunsg: I've just updated my timeline, in case you want to take a look
[15:01:18] <pradyunsg> McSinyx[m]: I'll take a look at it tonight. :)
[15:04:52] <McSinyx[m]> thanks! good night everyone (I not going to bed right-away but my brother is calling---he's abroad---gonna join my parents)
[15:31:56] <devesh> Hi pradyun: I had a question about an old issue with awaiting pr: https://github.com/pypa/pip/issues/7764
[17:58:21] <devesh> Sorry, I misspelled pradyunsg
[19:33:36] <devesh> Hi folks, I had a generic questin
[19:34:17] <devesh> How can I use a IDE, say pycharm and debug pip code such that I can place breakpoints when I run a specific command like "pip install" or "pip freeze"
[19:53:59] <pradyunsg> devesh: with some effort. 🙈
[19:54:15] <devesh> :) Like what effort?
[19:55:03] <devesh> Also why do we still py2 based checks for mypy, isn't py2 discontinued
[19:55:08] <pradyunsg> You'd want the IDE to run src/pip/__main__.py, in an environment that import pip uses src/pip (i.e. editable install)
[19:56:23] <pradyunsg> devesh: we still support Python 2. Googling "pip python 2 support" should surface the bunch of words we've written about it in our documentation.
[19:57:07] <pradyunsg> McSinyx[m]: I'll be looking at your proposal rn.
[19:57:07] <devesh> Okay, I tried today to take a myriad of issues and see what I can fix from pip, hope that's fine
[19:57:41] <devesh> I thought that maybe doing smaller pr's and getting an idea of code is a good way to get started, and hopefully in future lead to a feature
[19:58:47] <pradyunsg> devesh: yup. I don't know if we have the reviewer capacity *right now* to review them all (I've been pretty down mentally lately due to a whole bunch orlf resson, so my productivity has been really low lately)
[19:59:01] <pradyunsg> devesh: it is indeed!
[20:00:24] <pradyunsg> s/orlf/of/
[20:00:32] <devesh> pradyunsg: Yes I see that you don't have a lot of reviewers, and fewer merging folks
[20:01:18] <devesh> But I hope you get more people onboard, after people get hands-on with gsoc
[20:01:55] <devesh> it wasn't that big when I was studying, but now I see it has grown a lot
[20:02:23] <pradyunsg> I mean, *technically* I'm working on pip full time right now, but my mental health means that it's a lot less than I'd like it to be.
[20:04:10] <devesh> Aah, yes and with the things going around in the world, it's tougher than ever
[20:04:48] <devesh> I would say take a lot of breaks, and talk to people
[20:12:14] <travis-ci> pypa/pip#15296 (master - 720c77a : Pradyun Gedam): The build passed.
[20:12:14] <travis-ci> Change view : https://github.com/pypa/pip/compare/326efa5c710e...720c77aa387a
[20:12:14] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/668166297
[21:03:29] <pradyunsg> !logs
[21:03:29] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev
[21:12:35] <devesh> pradyunsg: Btw, how does one go about fixing mypy issues, the doc says remove one type: ignore at a time and fix it, and repeat
[21:12:51] <pradyunsg> devesh: Exactly like that.
[21:14:37] <devesh> pradyunsg: Got it, I will try the same, and will let the PR show how much of the approach actually worked
[21:15:08] <pradyunsg> devesh: facing any issues?
[21:17:53] <devesh> pradyunsg: Almost all the type: ignore in https://github.com/pypa/pip/blob/master/src/pip/_internal/cli/progress_bars.py#L133 is for instance variables not defined within DownloadProgressMixin
[21:18:38] <devesh> but I see them defined here: https://github.com/pypa/pip/blob/master/src/pip/_vendor/progress/__init__.py#L33
[21:18:51] <pradyunsg> Ahhhh. We don’t want to remove the ones on classes.
[21:18:55] <devesh> I am not even sure how these two classes are linked
[21:19:28] <pradyunsg> Look at #6727 — we only want to remove the # type: ignore commands added in that PR.
[21:21:07] <devesh> Yes, all the instance methods of the class I referred to have # type: ignore, introduced in that PR
[21:21:18] <devesh> e.g. https://github.com/pypa/pip/pull/6727/files#diff-c0f283b95b10dd142ff655046aaab89bR148
[21:21:32] <pradyunsg> Ahh.
[21:22:03] <pradyunsg> This probably needs a significantly deeper look into the situation than I can *right now*.
[21:22:31] <pradyunsg> None the less, your idea of removing the ones that are easy sounds good to me.
[21:22:53] <devesh> No worries, I will make an initial commit with the easy ones, and then we can discuss there on how to remove the difficult ones
[21:22:59] <pradyunsg> And we can discuss the remaining ones in the PR and figure out if it’s worth the effort to fix them.
[21:23:22] <devesh> When I say "easy", that means how much I can gather after reading mypy doc :)
[21:23:34] <pradyunsg> It’s all relative.
[21:23:39] <devesh> BTW how do you perform an action in IRC, like "pradyunsg nods in agreement."
[21:23:51] <pradyunsg> "/me nods in agreement"
[22:26:18] <travis-ci> pypa/twine#1346 (master - f7402e0 : Brian Rutledge): The build passed.
[22:26:18] <travis-ci> Change view : https://github.com/pypa/twine/compare/5482d6877df0cd90545c4708e5abe13b359f8a08...f7402e0d2e1c1e6ecde61dc8bcba515b807a48a0
[22:26:18] <travis-ci> Build details : https://travis-ci.org/pypa/twine/builds/668204108
[22:27:08] <travis-ci> pypa/pip#15297 (master - 720c77a : Pradyun Gedam): The build passed.
[22:27:08] <travis-ci> Change view : https://github.com/pypa/pip/compare/326efa5c710ecf19acc3e1315477251a4cd4bd13...720c77aa387a9a2d103fa065bd3a98904c90a7ec
[22:27:08] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/668198757