PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Sunday the 5th of April, 2020

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[04:38:49] <pradyunsg> devesh: you might've made a phrasing mistake here - you accidentally said "not different" instead of different/not same https://github.com/python/typeshed/issues/3906#issuecomment-609331139
[04:38:57] <pradyunsg> Oh Nvm.
[04:50:56] <devesh> Hi pradyunsg: Yes thanks for that :)
[04:51:07] <devesh> I have updated the text in my comment accordingly
[04:52:06] <devesh> and yay, we have a PR to fix it in typeshed as well
[04:53:21] <devesh> So we can get the file __init__.py updated in a future PR, but meanwhile, if the other PR looks good, can we approve/merge it :)
[10:53:32] <devesh> Hi Folks, I had a question about pip's test environment
[10:54:09] <devesh> How can I run a command in one of the tests with an env var, e.g. `PYTHONPATH=. pip list`
[11:11:16] <devesh> Okay I was able to do it using `script.environ.update({'PYTHONPATH': '.'})`
[15:54:50] <sangy> :( I wish people would stick around for a little longer
[15:55:28] <pradyunsg> sangy: lol, devesh has stuck around for quite a while actually. :P
[15:58:01] <devesh> pradyunsg: \o
[15:58:08] <devesh> Stuck around as in?
[16:10:13] <sangy> oh hey!
[16:10:25] <pradyunsg> devesh: o/
[16:11:00] <pradyunsg> devesh: sangy was sad that people leave after asking questions, without waiting for answers. :P
[16:11:54] <devesh> Yeah, the answer was stuck under the test code somewhere
[16:12:51] <devesh> btw, thanks for merging the pr about pip list, could you also approve/merge this
[16:12:59] <devesh> https://github.com/pypa/pip/pull/7977 , the type annotation one
[16:13:23] <pradyunsg> devesh: working on something else currently.
[16:13:45] <devesh> Sure no issues, whenever you can :)
[17:44:30] <devesh> Hi pradyunsg: Had a question, does adding unit tests in a PR, count as a trivial news entry?
[17:44:48] <devesh> Since that's something not needed in release notes
[20:33:21] <devesh> hi sangy: Sorry didn't see it earlier
[22:37:57] <travis-ci> pypa/pip#15518 (master - eb865b4 : Pradyun Gedam): The build passed.
[22:37:57] <travis-ci> Change view : https://github.com/pypa/pip/compare/feac59544639d36aa31b5fbd5d3b436f67a056ad...eb865b4e106ba33733414eebfcefafcd954fd184
[22:37:57] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/671395531