PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Tuesday the 19th of May, 2020

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[06:32:53] <travis-ci> pypa/packaging#954 (20.4 - ded06ce : Pradyun Gedam): The build passed.
[06:32:53] <travis-ci> Change view : https://github.com/pypa/packaging/compare/20.4
[06:32:53] <travis-ci> Build details : https://travis-ci.org/pypa/packaging/builds/688689863
[06:35:33] <pradyunsg> @deveshkusingh: if you’re looking for something to pick up in pip, here’s a PR that could use updating / revisiting: https://github.com/pypa/pip/pull/7869 :)
[06:39:14] <pradyunsg> gutsytechster: I mean, I hear you, but I’d prefer that we continue pinning to the Python minor version, and stick to newer versions wherever possible. Is there some reason you can’t install Python 3.8?
[06:40:10] <pradyunsg> Uhhh.
[06:40:11] <pradyunsg> gutsytechster (and devesh) — if one of you would like to pick up https://github.com/pypa/pip/pull/7869, that’d be great! ^>^
[06:40:27] <pradyunsg> (let’s just ignore how broken my IRC client is at times)
[06:42:00] <gutsytechster> pradyunsg: No specific reason. Just that I think, I should be able to do that irrespective of the specific version,
[06:42:22] <gutsytechster> pradyunsg: it happens with IRC> XD
[07:07:40] <gutsytechster> pradyunsg: I would definitely would like to work on https://github.com/pypa/pip/pull/7869, but how do I keep the changes present in that PR? Will it be like I fetch the PR's branch and checkout from it and then create another PR after resolving conflicts?
[07:17:43] <travis-ci> pypa/pip#16247 (master - e7dd02c : Pradyun Gedam): The build passed.
[07:17:43] <travis-ci> Change view : https://github.com/pypa/pip/compare/d4cd5b9d5d3d...e7dd02c7232a
[07:17:43] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/688693084
[07:20:00] <pradyunsg> gutsytechster: yea, you can do `git fetch origin refs/pull/7869/head && git checkout -b <any-new-branch-name>` to get those changes.
[07:20:13] <pradyunsg> (assuming the remote name for pypa/pip is origin)
[07:20:36] <gutsytechster> great, thanks
[07:22:08] <pradyunsg> It'd probably make sense to break that PR up, to keep it smaller. A PR just adding the helpers would be a good place to start. :)
[07:22:55] <pradyunsg> We can likely updating various call sites (i.e. update the tests) in separate PRs.
[07:26:27] <pradyunsg> Hmm... Interesting.
[07:26:49] <pradyunsg> I'm also on IRCCloud. And these folks were too.
[07:29:03] <pradyunsg> And they're back.
[07:29:44] <pradyunsg> gutsytechster: (see my message ~7 minutes ago)
[07:30:33] <gutsytechster> pradyunsg: yeah, that makes sense.
[07:43:49] <PSFSlack> <deveshkusingh> gutsytechster: Have you already picked that #7689 up?
[07:45:07] <pradyunsg> Alrighty! I'll be going AFK for lunch now.
[07:45:54] <gutsytechster> PSFSlack: yeah, just fetched the branch and checked out from it!
[07:46:01] <gutsytechster> Were you working over it?
[07:46:37] <PSFSlack> <deveshkusingh> Nope, I just saw this message.
[07:46:57] <PSFSlack> <deveshkusingh> I think if you have checked out the branch, you can continue working on it
[07:47:22] <gutsytechster> Ah ok. Thanks
[07:48:13] <PSFSlack> <deveshkusingh> There is a also a larger PR https://github.com/pypa/pip/pull/7860 to which #7689 contributes too, which also needs to be resurrected
[07:48:26] <PSFSlack> <deveshkusingh> I can perhaps take a stab at it. cc: pradyunsg
[07:56:10] <PSFSlack> <deveshkusingh> gutsytechster: w.r.t overriding basepython in a lower python virtualenv, I think you can also file an issue with https://github.com/tox-dev/tox/issues to either add that option
[07:56:22] <PSFSlack> <deveshkusingh> Or point you on how to do it in the docs
[07:58:07] <PSFSlack> <deveshkusingh> btw, since I am using the IRC-Slack bridge to conect here, you can use @deveshkusingh to refer to me.
[08:10:27] <pradyunsg> @deveshkusingh: IIUC, you're thinking of picking up https://github.com/pypa/pip/issues/6050? If so, that sounds awesome!
[08:16:23] <pradyunsg> @deveshkusingh: Another thing, that I believe is on your radar: getting rid of the `# type: (*Any, **Any) -> None` style comments from pip's Command subclasses. :)
[08:47:05] <PSFSlack> <deveshkusingh> pradyunsg: Yes getting rid of `# type: (*Any, **Any) -> None` is on my radar, I was aiming to get rid of all mypy commments from commands folder before doing that
[08:47:59] <PSFSlack> <deveshkusingh> I already have an issue filed for getting rid of those, and yes I can tackle https://github.com/pypa/pip/issues/6050 as well.
[10:54:08] <gutsytechster> @deveshkusingh: I guess that'd be really helpful. I'll file an issue there. Thanks
[10:55:23] <PSFSlack> <deveshkusingh> And you can always start using python3.8 for development if this doesn't work out for you
[11:00:42] <gutsytechster> @deveshkusingh: I have, after facing that problem. I updated my python version to 3.8.2. I thought it's better now than later. :)
[18:11:55] <sumanah> hi techalchemy - am here
[18:12:33] <sumanah> hope you are doing all right
[23:07:38] <travis-ci> pypa/pip#16266 (master - 15f0863 : Pradyun Gedam): The build passed.
[23:07:38] <travis-ci> Change view : https://github.com/pypa/pip/compare/993531179c653b331807077e14d0db68b1da3159...15f0863a6531fd5130d3afcfd5ffdc5868356184
[23:07:39] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/689026705