Log file Viewer

[08:53:16] <travis-ci> pypa/pip#16272 (master - 803a6f2 : Stéphane Bidoul): The build passed.

[08:53:16] <travis-ci> Change view : https://github.com/pypa/pip/compare/15f0863a6531...803a6f201727

[08:53:16] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/689151225

[09:02:34] <gutsytechster> Breaking someone else's PR would mean distributing its commit across multiple branches. Is that what we do? Since, the PR has a lot of changes and commits. How do we keep only specific change?

[09:03:23] <gutsytechster> One way I think is to manually copy the changes and add the PR's author as a co-author? Or do we usually take some other route?

[09:06:56] <gutsytechster> @deveshkusingh^^ I think you have already done some work like this.

[09:14:33] <McSinyx[m]> gutsytechster, could you please provide some context

[09:14:46] <McSinyx[m]> I'm curious on what you're referring to

[09:16:28] <gutsytechster> McSinyx[m]: Ah sorry my bad. I am actually working on https://github.com/pypa/pip/pull/7869. However I have to break this PR in multiple PRs with small changes

[09:41:51] <McSinyx[m]> I think that the manual patches apply seems best

[09:42:58] <McSinyx[m]> but I'm not experienced enough to make my suggestion to have any weight though

[10:03:39] <PSFSlack> <deveshkusingh> One thing I can think of is that you manually pull the PR using `git fetch origin refs/pull/7869/head` and that in your new smaller PR, cherry pick the commits if you can and then apply them to your smaller PR

[10:06:40] <PSFSlack> <deveshkusingh> Perhaps this can help: https://stackoverflow.com/questions/30768148/git-split-pull-request-into-smaller-prs-based-upon-the-new-directories-in-the

[10:07:27] <PSFSlack> <deveshkusingh> And yes, manually copying the changes and adding PR's author as co-author seems to be the easiest way to go, and you can avoid manually pulling the PR too

[10:08:31] <PSFSlack> <deveshkusingh> I have burned my hands in git commands a lot of times, so I would tread with care when using them if you go the cherry-pick/rebase route

[10:29:25] <gutsytechster> @deveshkusingh thanks for the approach!

[10:34:51] <gutsytechster> McSinyx[m]: Regarding this https://github.com/pypa/pip/pull/8266#issuecomment-631373951. Surely I was unaware about purelib and platlib directories. So, as you said if any extension is to be installed, it would go into platlib.

[10:35:40] <gutsytechster> So shouldn't pip only consider platlib, as purelib is not the place for extension modules. And pip would actually install the extensions.

[10:36:09] <McSinyx[m]> I blame my burn out after biking under 37 degrees C, but I don't understand what you mean

[10:37:07] <McSinyx[m]> e.g. pip would be installed under purelib I think

[10:38:21] <gutsytechster> McSinyx[m]: XD. Let me rephrase it. Surely I am most of the times difficult to understand. Now, this is the second experience when someone couldn't understand what I said in last two days.

[10:38:38] <gutsytechster> McSinyx[m]: ok, yeah. pip would go to purelib

[10:39:41] <McSinyx[m]> lol actually my physical burnt out is real, I take like 1 min to parse what my parents said in my native language

[10:41:05] <gutsytechster> So, how do we determine where the package should go. I mean would it then depend on the package?

[10:41:22] <gutsytechster> McSinyx[m]: lmao. It happens. Hope you get alright soon.

[10:41:23] <McSinyx[m]> that's what I believe

[10:41:42] <McSinyx[m]> thanks!

[10:42:17] <gutsytechster> I see.

[10:43:58] <gutsytechster> But shouldn't this work have already been done? I mean when installing, pip would determine the install location beforehand.

[10:46:05] <gutsytechster> I see that pip further passes `lib_location_guesses` to WorkingSet https://github.com/pypa/pip/blob/803a6f201727a3b64faf976854bac70a1e411150/src/pip/_internal/commands/install.py#L414

[11:01:41] <McSinyx[m]> if i understand the code correctly, that part only check if pkgs are installed correctly

[11:02:19] <McSinyx[m]> so yes, the underlying logics for location determination are deep down the call to install given reqs

[11:05:34] <McSinyx[m]> IIRC some uses the distutils scheme directly (wheel?), some rely on setuptools/distutils logic which does the same thing

[13:03:02] <PSFSlack> <deveshkusingh> gutsytechster: I see that PR #7869 was just now updated. So I guess you should ask there if you can take it over and continue it, or the original PR creator still is available to work on it

[13:03:25] <gutsytechster> @deveshkusingh, yeah just saw that.

[13:03:31] <gutsytechster> I was writing the comment over it.

[13:03:42] <gutsytechster> thanks for informing

[13:04:29] <PSFSlack> <deveshkusingh> cool

[13:13:01] <gutsytechster> McSinyx[m]: I see.

[13:13:09] <gutsytechster> I'll have a look at the code then.

[18:17:55] <sumanah> techalchemy: how are you doing today?

[20:18:46] <techalchemy> sumanah: i'm ok whenever you pop back in, i just actually re-released things

[23:07:42] <travis-ci> pypa/pip#16288 (master - 9999f0e : Paul Moore): The build passed.

[23:07:42] <travis-ci> Change view : https://github.com/pypa/pip/compare/418d9051b87ff1069990163dc9f7c8eeb7863e9a...9999f0ec098f9dc4687eecd118f52a3233e64e8c

[23:07:42] <travis-ci> Build details : https://travis-ci.org/pypa/pip/builds/689447399