PMXBOT Log file Viewer

Help | Karma | Search:

#pypa-dev logs for Thursday the 27th of August, 2020

(Back to #pypa-dev overview) (Back to channel listing) (Animate logs)
[00:03:01] <travis-ci> pypa/pip#17852 (master - 0b18e21 : Pradyun Gedam): The build passed.
[00:03:01] <travis-ci> Change view : https://github.com/pypa/pip/compare/b7075b9351ef220f609e8b7bbd6045c626653fb0...0b18e21cbe64b1bd089e280fd8ba592cdbfcac61
[00:03:01] <travis-ci> Build details : https://travis-ci.com/pypa/pip/builds/181563810
[05:51:37] <gutsytechster> !logs
[05:51:37] <pmxbot> http://kafka.dcpython.org/channel/pypa-dev
[10:39:55] <pradyunsg> gutsytechster: if you run `pip uninstall django` w/ Django installed -- you'll notice that it prints "site-packages/django/*" instead of listing all the files. That's what the "compress_for_rename" function does. :)
[10:41:30] <pradyunsg> gutsytechster: when you're not sure what a chunk of code does, try to look at the tests for the code. If they're written properly, they can provide hints as to what the code does.
[10:41:31] <pradyunsg> https://github.com/pypa/pip/blob/b1bc41b2c34c74e11cc6951a4ff4f132a2acd6dd/tests/unit/test_req_uninstall.py#L55
[10:44:44] <pradyunsg> oh wait, I mis-spoke -- compress_for_rename is trying to minimize the number of rename calls we make; if we're moving all the files within a folder, we move the folder instead of trying to move every file one-by-one.
[10:44:51] <pradyunsg> *why* -- I don't know. :)