[16:37:14] <rnix> hi, i cythonized some modules of a python package and tried to create an egg with python setup.py bdist_egg --exclude-source-files. The contained *.so files are included, but also the compiled pyc files are and the 'so' files never are used.
[16:37:59] <rnix> is setuptools not able to correctly build eggs with cythonized files or might this be an error when cythonize files with py extension instead of pyx?
[16:46:43] <ronny> rnix: setuptools is reassonably unaware of cython, you could exclude those files
[16:47:20] <rnix> well after cythoning the modules are just shared objects.
[16:48:06] <rnix> and the source code of setuptools semm to be aware of shared objects - https://bitbucket.org/pypa/setuptools/src/acb8319982f13971962e94d77a71c79befce87c4/setuptools/command/bdist_egg.py?at=default#cl-326
[16:48:57] <rnix> so there might be a problem when building so files from py files instead of pyx files
[16:49:32] <rnix> the thing is that installing from sdist works
[16:55:32] <ronny> rnix: did you exclude them from find_packages?
[22:05:04] <_habnabit> https://github.com/pypa/pip/compare/develop...habnabit:extras-set-union?expand=1 is there any chance of this getting added to pip, before i actually make a merge request of it?
[22:05:19] <_habnabit> pull requests just seem so rude
[22:21:01] <glyph> _habnabit: why do you think PRs are rude? I have my own ideas, but I'm curious why you think so
[22:21:15] <sontek> PRs are like tea. You can offer someone tea but if they don't want it don't force them to drink it.
[22:21:16] <glyph> _habnabit: I tend to think they're rude because you should file a ticket first
[22:21:27] <_habnabit> glyph, it's not saying "hey, i have a problem; how should i solve it?" it's saying "HI PLZ MERGE"
[22:21:45] <_habnabit> glyph, there's no collaboration
[22:21:53] <glyph> _habnabit: right, issue first, then PR that closes it, so that the maintainer has some way to say "valid problem but your implementation sucks so bad I don't want to look at it"
[22:21:54] <_habnabit> until (maybe) after the fact
[22:21:55] <cyli> how is that different than filing a ticket, and submitting a patch along with the ticket on track or something?
[22:22:08] <_habnabit> cyli, it's not different, if you file the patch immediately with the issue
[22:22:15] <glyph> cyli: on trac, a person can submit a new patch, or divert a different branch, to the same ticket
[22:22:25] <cyli> _habnabit: do you have to wait for acknowledgement of an issue before filing a patch?
[22:22:45] <_habnabit> cyli, that's the part i'm not sure about
[22:22:46] <glyph> cyli: on github, you generally make PRs of branches on your own fork, so you either close the PR or you land it as the original submitter wants
[22:23:06] <_habnabit> cyli, but i know that means a slower feedback loop
[22:23:28] <glyph> _habnabit: i'd file the ticket and submit the PR immediately; it's not rude to say "here would you like this" but it is rude to say "I don't want to explain why you should land this, just do it do it dooooo iiiiiiit"
[22:23:44] <glyph> _habnabit: but, if you do file an issue, waiting to submit the patch is just holding back, slowing down the feedback cycle for the person reviewing it as well
[22:24:22] <glyph> anyway I think we are, compared to pip's maintainers, way overthinking this :) most people are just happy to have a PR, especially if your description is clear enough
[22:24:46] <glyph> most projects if they end up in the situation where there is a valid problem but they don't like the implementation strategy, are perfectly happy to copy and paste gobs of text from the PR into an issue, maybe link it (or maybe not)
[22:25:04] <cyli> _habnabit: It seems efficient to provide a solution if you happen to have one, and that lets people use your solution as a workaround until the maintainers get around to reviewing your patch
[22:25:14] <glyph> I hate that but I am willing to accept that my emoitional reaction is based on the fact that I was a process consultant for several years and it is therefore a problem with me
[22:25:21] <cyli> _habnabit: which could take months
[22:26:08] <glyph> _habnabit: cyli is considerably more in touch with the "normal" open source community on github than we are, we should probably just listen to her :)
[22:26:57] <_habnabit> i'm perfectly ok with doing that, haha
[22:27:06] <cyli> _habnabit: I'm not disagreeing with anyone about issues vs pull requests, juts my thought on submitting a bug + solution at the same time :)
[22:28:06] <cyli> maintainers could choose to ignore the solution, after all, or go with a different one.
[22:33:57] <cyli> _habnabit: although I can see what you mean - if you already submit a solution, there's a sort of social pressure on the part of the maintainers to accept it, or they might feel bad about rejecting already-done work.
[22:37:26] <cyli> _habnabit: I wish we could just formalize this as a social norm. :| Like if there were a well understood rule that rejecting work was perfectly valid, maybe it wouldn't be as bad? Certainly I feel better when travis or coveralls rejects a PR for me, and I can just be like "Oh, I'm sorry, but this inhuman automated system has rejected your work based on these rules that are laid out in this contributing document here. My hands are tied."
[23:38:08] <glyph> dstufft: I'm still working on understanding why pbr is installed, so, it's all good ;)
[23:50:58] <glyph> dstufft: perhaps the most appropriate usage of this particular meme, given the picture of the crown: http://www.keepcalm-o-matic.co.uk/p/dehumanize-yourself-and-face-to-bloodshed-2/
[23:58:02] <glyph> okay so ... pbr is _not_ installed globally
[23:59:34] <glyph> but pip is trying to uninstall it