PMXBOT Log file Viewer

Help | Karma | Search:

#pypa logs for Wednesday the 27th of November, 2019

(Back to #pypa overview) (Back to channel listing) (Animate logs)
[12:59:21] <tos9> Has anyone written a style guide on what should go in a MANIFEST?
[12:59:41] <tos9> check-manifest is certainly an implicit one (and I'm aware of it), but I think I disagree with its answer (which is "everything")
[16:24:02] <astronavt> tos9 i dont know of a specific style guide but typically i just `graft src/` and `include` any other top level files i want to include in the sdist (license, readme, etc)
[16:26:08] <ngoldbaum> it's not really a style guide but there's https://packaging.python.org/guides/using-manifest-in/#using-manifest-in
[18:36:31] <tos9> astronavt: same -- my question is how many of us have the *same* notion of those "other top level files" :)
[18:37:19] <tos9> (e.g. pyproject.toml is an obvious thing I was forgetting to include, but an example folder say is not one I would include)
[18:37:41] <tos9> ngoldbaum: yeah thanks, I've read that probably a few times
[18:52:35] <astronavt> its hard for me because personally i have a poor sense of when someone would even want to use an sdist
[18:52:51] <astronavt> other than "looking at the files because its open source"
[23:36:40] <tos9> astronavt: eh that part is easy to me
[23:37:13] <tos9> astronavt: until super low barrier PAASes for wheel building across every configuration under the sun exist, the answer is simply "when a wheel isn't available for your architecture"
[23:38:07] <astronavt> so then just include the minimum you need to install correctly, right? whatever you need from setup.py/pyproject.toml
[23:38:07] <tos9> the overwhelming majority (99%+?) of packages big and small don't even have wheels for all 3 OSes and all 2 important Python interpreters, so we're still quite a ways away from getting rid of sdists :P
[23:38:20] <tos9> astronavt: That'd be what I'd write into my style guide yes :)
[23:38:32] <tos9> astronavt: slightly more than that -- LICENSE doesn't change behavior say, but is "required metadata"
[23:38:41] <astronavt> hmm right
[23:38:43] <tos9> But yeah my personal opinion would essentially be that.
[23:39:04] <tos9> (Which is why I asked whether anyone had written that down -- if not well yeah ok guess I get to do it)